You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/09/10 15:31:05 UTC

Review Request 25501: Ambari items in /tmp

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25501/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-7239
    https://issues.apache.org/jira/browse/AMBARI-7239


Repository: ambari


Description
-------

I notice two items in /tmp:

ambari_commons  
ambari-server

Looks like ambari-server (on ambari server machine) after I downloaded ZK
client configs (so this might be related to all client config generation):

    
    
    
    [vagrant@c6401 tmp]$ cd ambari-server/
    [vagrant@c6401 ambari-server]$ ls
    ZOOKEEPER_CLIENT-configs.tar.gz  ZOOKEEPER_CLIENT-configuration.json
    

Looks like ambari_commons had things related to host registration / checks (on
any agent machine):

    
    
    
    [vagrant@c6401 tmp]$ cd ambari_commons/
    [vagrant@c6401 ambari_commons]$ ls
    firewall.py  firewall.pyc  __init__.py  __init__.pyc  os_check.py  os_check.pyc
    

I also saw these files (on ambari-server machine and agent machines):

    
    
    
    -rwxr-xr-x 1 vagrant vagrant 1539 Sep  5 01:36 os_check_type1409880999.py
    -rwxr-xr-x 1 vagrant vagrant 8361 Sep  5 01:36 setupAgent1409881000.py
    


Diffs
-----

  ambari-server/conf/unix/ambari.properties b77ae32 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java 16a8ffa 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java 35c7826 
  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java ae20d43 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java cc97eba 
  ambari-server/src/main/python/bootstrap.py b981572 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java e7ecb88 
  ambari-server/src/test/python/TestBootstrap.py d511222 

Diff: https://reviews.apache.org/r/25501/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 25501: Ambari items in /tmp

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25501/#review52872
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Сен. 10, 2014, 1:31 п.п., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25501/
> -----------------------------------------------------------
> 
> (Updated Сен. 10, 2014, 1:31 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-7239
>     https://issues.apache.org/jira/browse/AMBARI-7239
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I notice two items in /tmp:
> 
> ambari_commons  
> ambari-server
> 
> Looks like ambari-server (on ambari server machine) after I downloaded ZK
> client configs (so this might be related to all client config generation):
> 
>     
>     
>     
>     [vagrant@c6401 tmp]$ cd ambari-server/
>     [vagrant@c6401 ambari-server]$ ls
>     ZOOKEEPER_CLIENT-configs.tar.gz  ZOOKEEPER_CLIENT-configuration.json
>     
> 
> Looks like ambari_commons had things related to host registration / checks (on
> any agent machine):
> 
>     
>     
>     
>     [vagrant@c6401 tmp]$ cd ambari_commons/
>     [vagrant@c6401 ambari_commons]$ ls
>     firewall.py  firewall.pyc  __init__.py  __init__.pyc  os_check.py  os_check.pyc
>     
> 
> I also saw these files (on ambari-server machine and agent machines):
> 
>     
>     
>     
>     -rwxr-xr-x 1 vagrant vagrant 1539 Sep  5 01:36 os_check_type1409880999.py
>     -rwxr-xr-x 1 vagrant vagrant 8361 Sep  5 01:36 setupAgent1409881000.py
>     
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/ambari.properties b77ae32 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java 16a8ffa 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java 35c7826 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java ae20d43 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java cc97eba 
>   ambari-server/src/main/python/bootstrap.py b981572 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java e7ecb88 
>   ambari-server/src/test/python/TestBootstrap.py d511222 
> 
> Diff: https://reviews.apache.org/r/25501/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>