You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/08/18 13:27:12 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request, #2863: tinyusb: Allow for several CDC interfaces

kasjer opened a new pull request, #2863:
URL: https://github.com/apache/mynewt-core/pull/2863

   This adds way to have several CDC interfaces (COM ports or /dev/ttyACMx devices) on one USB devices.
   This will allow to have USB console with other serial based interface like HCI over serial connection.
   
   cdc package is added that routes TinyUSB CDC devices callbacks to multiply interface implementations.
   
   Some USB string descriptor handling is also updated so string indices for interfaces and DFU slot are no longer hardcode.
   
   This also adds standard descriptor for CDC HCI that can be used by future nimble transport.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2863: tinyusb: Allow for several CDC interfaces

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2863:
URL: https://github.com/apache/mynewt-core/pull/2863#issuecomment-1220298643

   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] wes3 commented on a diff in pull request #2863: tinyusb: Allow for several CDC interfaces

Posted by GitBox <gi...@apache.org>.
wes3 commented on code in PR #2863:
URL: https://github.com/apache/mynewt-core/pull/2863#discussion_r950155929


##########
hw/usb/tinyusb/std_descriptors/include/tusb_config.h:
##########
@@ -118,7 +153,13 @@ extern "C" {
 #define CFG_CDC_CONSOLE          0
 #endif
 
-#define CFG_TUD_CDC              ((CFG_CDC) + (CFG_CDC_CONSOLE))
+#if MYNEWT_VAL(USBD_CDC_HCI)

Review Comment:
   Is USBD_CDC_I defined in any syscfg.yml file? I could not find it but maybe it is in a different PR or commit or I missed it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] kasjer merged pull request #2863: tinyusb: Allow for several CDC interfaces

Posted by GitBox <gi...@apache.org>.
kasjer merged PR #2863:
URL: https://github.com/apache/mynewt-core/pull/2863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2863: tinyusb: Allow for several CDC interfaces

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #2863:
URL: https://github.com/apache/mynewt-core/pull/2863#issuecomment-1219637180

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/usb/tinyusb/cdc/src/cdc.c
   <details>
   
   ```diff
   @@ -69,7 +69,7 @@
    
    /* Invoked when line coding is change via SET_LINE_CODING */
    void
   -tud_cdc_line_coding_cb(uint8_t itf, cdc_line_coding_t const* p_line_coding)
   +tud_cdc_line_coding_cb(uint8_t itf, cdc_line_coding_t const * p_line_coding)
    {
        cdc_itf_t *cdc_itf = cdc_itfs[itf];
    
   ```
   
   </details>
   
   #### hw/usb/tinyusb/std_descriptors/src/std_descriptors.c
   <details>
   
   ```diff
   @@ -319,7 +319,8 @@
    #endif
    
    #if CFG_CDC_CONSOLE
   -    TUD_CDC_DESCRIPTOR(ITF_NUM_CDC_CONSOLE, CDC_CONSOLE_IF_STR_IX, USBD_CDC_CONSOLE_NOTIFY_EP, USBD_CDC_CONSOLE_NOTIFY_EP_SIZE,
   +    TUD_CDC_DESCRIPTOR(ITF_NUM_CDC_CONSOLE, CDC_CONSOLE_IF_STR_IX, USBD_CDC_CONSOLE_NOTIFY_EP,
   +                       USBD_CDC_CONSOLE_NOTIFY_EP_SIZE,
                           USBD_CDC_CONSOLE_DATA_OUT_EP, USBD_CDC_CONSOLE_DATA_IN_EP,
                           (CFG_TUSB_RHPORT0_MODE & OPT_MODE_HIGH_SPEED) ? 512 : USBD_CDC_CONSOLE_DATA_EP_SIZE),
    #endif
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org