[GitHub] [incubator-nuttx] yamt commented on pull request #1592: libxx: Integrate libc++ latest official release

[GitBox <gi...@apache.org>]

yamt commented on pull request #1592:
URL: https://github.com/apache/incubator-nuttx/pull/1592#issuecomment-715301848


   @xiaoxiang781216 
   can you explain about libs/libxx/libxx_impure.cxx?
   for which configurations is it necessary?
   with what version of libsupc++ and reent.h?
   
   for me it's broken.
   https://github.com/apache/incubator-nuttx/pull/2063 + a few esp32 patch.
   xtensa/esp32, with ESP-IDF provided gcc/libsupc++. (esp-2020r3-8.4.0)
   reverting this libxx_impure.cxx commit makes it builds.
   ```
   libxx_impure.cxx:58:50: error: conflicting declaration '_reent* const _global_impure_ptr'
       struct _reent *const __ATTRIBUTE_IMPURE_PTR__ _global_impure_ptr = &impure_data;
                                                     ^~~~~~~~~~~~~~~~~~
   In file included from /Users/yamamoto/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/xtensa-esp32-elf/sys-include/reent.h:93,
                    from libxx_impure.cxx:27:
   /Users/yamamoto/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/xtensa-esp32-elf/sys-include/sys/reent.h:778:24: note: previous declaration as '_reent* _global_impure_ptr'
    extern struct _reent * _global_impure_ptr __ATTRIBUTE_IMPURE_PTR__;
                           ^~~~~~~~~~~~~~~~~~
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org