You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/11/10 23:43:53 UTC
[kudu-CR] tablet copy: Rename tablet copy session source files
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5042
to review the following change.
Change subject: tablet copy: Rename tablet copy session source files
......................................................................
tablet copy: Rename tablet copy session source files
This is just a quick cleanup to the class rename in the previous commit.
Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
---
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_copy_service.cc
R src/kudu/tserver/tablet_copy_source_session-test.cc
R src/kudu/tserver/tablet_copy_source_session.cc
R src/kudu/tserver/tablet_copy_source_session.h
5 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/5042/1
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet copy: Rename tablet copy session source files
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5042
to look at the new patch set (#3).
Change subject: tablet copy: Rename tablet copy session source files
......................................................................
tablet copy: Rename tablet copy session source files
This is just a quick cleanup to the class rename in the previous commit.
Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
---
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_copy_service.cc
R src/kudu/tserver/tablet_copy_source_session-test.cc
R src/kudu/tserver/tablet_copy_source_session.cc
R src/kudu/tserver/tablet_copy_source_session.h
5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/5042/3
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet copy: Rename tablet copy session source files
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Rename tablet copy session source files
......................................................................
Patch Set 1:
this seems to need a manual rebase
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tablet copy: Rename tablet copy session source files
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Rename tablet copy session source files
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] tablet copy: Rename tablet copy session source files
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: tablet copy: Rename tablet copy session source files
......................................................................
tablet copy: Rename tablet copy session source files
This is just a quick cleanup to the class rename in the previous commit.
Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Reviewed-on: http://gerrit.cloudera.org:8080/5042
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_copy_service.cc
R src/kudu/tserver/tablet_copy_source_session-test.cc
R src/kudu/tserver/tablet_copy_source_session.cc
R src/kudu/tserver/tablet_copy_source_session.h
5 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet copy: Rename tablet copy session source files
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5042
to look at the new patch set (#2).
Change subject: tablet copy: Rename tablet copy session source files
......................................................................
tablet copy: Rename tablet copy session source files
This is just a quick cleanup to the class rename in the previous commit.
Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
---
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/tablet_copy_service.cc
R src/kudu/tserver/tablet_copy_source_session-test.cc
R src/kudu/tserver/tablet_copy_source_session.cc
R src/kudu/tserver/tablet_copy_source_session.h
5 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/5042/2
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I23da316bc3c5d5de412d2d86b1bc7ee77ef60be5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>