You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2024/01/08 04:03:46 UTC
[PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
1996fanrui opened a new pull request, #24040:
URL: https://github.com/apache/flink/pull/24040
[FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #24040:
URL: https://github.com/apache/flink/pull/24040#discussion_r1444232288
##########
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java:
##########
@@ -89,11 +89,10 @@ public class RestartStrategyOptions {
"here")))
.text(
"If checkpointing is disabled, the default value is %s. "
- + "If checkpointing is enabled, the default value is %s with %s restart attempts and '%s' delay.",
+ + "If checkpointing is enabled, the default value is %s, and the values of all %s related options have not changed.",
Review Comment:
Hi @zhuzhurk , do you have any good suggestion about the doc of default restart strategy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #24040:
URL: https://github.com/apache/flink/pull/24040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24040:
URL: https://github.com/apache/flink/pull/24040#issuecomment-1880359291
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "897dba2811c190461951040a2bd696fca4a18c88",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "897dba2811c190461951040a2bd696fca4a18c88",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 897dba2811c190461951040a2bd696fca4a18c88 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #24040:
URL: https://github.com/apache/flink/pull/24040#discussion_r1445953255
##########
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java:
##########
@@ -89,11 +89,10 @@ public class RestartStrategyOptions {
"here")))
.text(
"If checkpointing is disabled, the default value is %s. "
- + "If checkpointing is enabled, the default value is %s with %s restart attempts and '%s' delay.",
+ + "If checkpointing is enabled, the default value is %s, and the values of all %s related options have not changed.",
Review Comment:
Thanks for the suggestion! It's better than before, I updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #24040:
URL: https://github.com/apache/flink/pull/24040#issuecomment-1884091150
Thanks to everyone for the review! The CI is green for now, merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on code in PR #24040:
URL: https://github.com/apache/flink/pull/24040#discussion_r1445945589
##########
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java:
##########
@@ -89,11 +89,10 @@ public class RestartStrategyOptions {
"here")))
.text(
"If checkpointing is disabled, the default value is %s. "
- + "If checkpointing is enabled, the default value is %s with %s restart attempts and '%s' delay.",
+ + "If checkpointing is enabled, the default value is %s, and the values of all %s related options have not changed.",
Review Comment:
maybe "and the values of all %s related options have not changed." -> "and the default values of %s related config options will be used."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33738][Scheduler] Make exponential-delay restart-strategy the default restart strategy [flink]
Posted by "qinf (via GitHub)" <gi...@apache.org>.
qinf commented on PR #24040:
URL: https://github.com/apache/flink/pull/24040#issuecomment-1882535964
Thank you @1996fanrui for your contribution, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org