You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/06/20 21:49:28 UTC
Review Request 35700: Views : Error deploying all non-system views

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35700/
-----------------------------------------------------------

Review request for Ambari and Mahadev Konar.


Bugs: AMBARI-12048
    https://issues.apache.org/jira/browse/AMBARI-12048


Repository: ambari


Description
-------

View registry attempting to read the descriptor from the extracted view archive before doing the extraction.

Regression introduced by AMBARI-11991.

    19 Jun 2015 19:39:55,002  INFO [pool-4-thread-5] ViewRegistry:1535 - Reading view archive /var/lib/ambari-server/resources/views/pig-2.1.0.1168.jar.
    19 Jun 2015 19:39:55,021 ERROR [pool-4-thread-5] ViewRegistry:1567 - Caught exception loading view PIG{1.0.0}
    java.io.FileNotFoundException: /var/lib/ambari-server/resources/views/work/PIG{1.0.0}/WEB-INF/classes/view.xml (No such file or directory)
        at java.io.FileInputStream.open0(Native Method)
        at java.io.FileInputStream.open(FileInputStream.java:195)
        at java.io.FileInputStream.<init>(FileInputStream.java:138)
        at org.apache.ambari.server.view.ViewArchiveUtility.getViewConfigFromExtractedArchive(ViewArchiveUtility.java:116)
        at org.apache.ambari.server.view.ViewRegistry.readViewArchive(ViewRegistry.java:1539)
        at org.apache.ambari.server.view.ViewRegistry.access$000(ViewRegistry.java:119)
        at org.apache.ambari.server.view.ViewRegistry$5.run(ViewRegistry.java:1492)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java c7630ed 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java 0472756 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 28016ea 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 09df011 

Diff: https://reviews.apache.org/r/35700/diff/


Testing
-------

Manual tested to verify that all views are deployed.

mvn clean test

results pending ...


Thanks,

Tom Beerbower