You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/17 14:10:39 UTC

[GitHub] [incubator-nuttx] davids5 commented on a diff in pull request #6287: stm32h7: allow definition of HSI divider in board config

davids5 commented on code in PR #6287:
URL: https://github.com/apache/incubator-nuttx/pull/6287#discussion_r874867847


##########
arch/arm/src/stm32h7/stm32h7x3xx_rcc.c:
##########
@@ -98,6 +98,12 @@
 #  define USE_PLL3
 #endif
 
+#ifdef STM32_BOARD_USEHSI
+#ifndef STM32_BOARD_HSIDIV
+#error When HSI is used, you have to define STM32_BOARD_HSIDIV in board/include/board.h

Review Comment:
   To not make this a breaking change, how about this?
   
   ```suggestion
   #define STM32_BOARD_HSIDIV RCC_CR_HSIDIV_4
   #warn default STM32_BOARD_HSIDIV set to RCC_CR_HSIDIV_4 to override define STM32_BOARD_HSIDIV in board/include/board.h
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org