You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2022/11/29 09:47:18 UTC
[spark] branch master updated: [SPARK-41256][CONNECT][FOLLOWUP] Fix compile error
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 86e1df4e44c [SPARK-41256][CONNECT][FOLLOWUP] Fix compile error
86e1df4e44c is described below
commit 86e1df4e44cb5b2ce3a8215eab6c89a7f46811f9
Author: Ruifeng Zheng <ru...@apache.org>
AuthorDate: Tue Nov 29 18:47:06 2022 +0900
[SPARK-41256][CONNECT][FOLLOWUP] Fix compile error
### What changes were proposed in this pull request?
https://github.com/apache/spark/commit/4c35c5bb5e545acb2f46a80218f68e69c868b388 made a breaking change in proto message, and cause https://github.com/apache/spark/commit/dcd9cae4a3cb715aa91e9679b0adc9aa43035b2f failed after merged
### Why are the changes needed?
to fix compile error:
```
[error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:441:67: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder
[error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32))))
[error] ^
[error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:446:67: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder
[error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32)))))
[error] ^
[error] /__w/spark/spark/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:466:69: value setI32 is not a member of org.apache.spark.connect.proto.Expression.Literal.Builder
[error] .setLiteral(proto.Expression.Literal.newBuilder.setI32(32)))))
[error] ^
[error] three errors found
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
local test
Closes #38837 from zhengruifeng/connect_hot_fix.
Authored-by: Ruifeng Zheng <ru...@apache.org>
Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
.../apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala b/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala
index 007452cfa3b..8fbf2be3730 100644
--- a/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala
+++ b/connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala
@@ -438,12 +438,12 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
.newBuilder()
.addName("test")
.setExpr(proto.Expression.newBuilder
- .setLiteral(proto.Expression.Literal.newBuilder.setI32(32))))
+ .setLiteral(proto.Expression.Literal.newBuilder.setInteger(32))))
.addNameExprList(proto.Expression.Alias
.newBuilder()
.addName("test")
.setExpr(proto.Expression.newBuilder
- .setLiteral(proto.Expression.Literal.newBuilder.setI32(32)))))
+ .setLiteral(proto.Expression.Literal.newBuilder.setInteger(32)))))
.build())
}
}
@@ -463,7 +463,7 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
.addName("part1")
.addName("part2")
.setExpr(proto.Expression.newBuilder
- .setLiteral(proto.Expression.Literal.newBuilder.setI32(32)))))
+ .setLiteral(proto.Expression.Literal.newBuilder.setInteger(32)))))
.build())
}
assert(e.getMessage.contains("part1, part2"))
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org