You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/12/17 02:08:40 UTC
[GitHub] [kafka] mjsax commented on a change in pull request #11535: KAFKA-13476: Increase resilience timestamp decoding Kafka Streams
mjsax commented on a change in pull request #11535:
URL: https://github.com/apache/kafka/pull/11535#discussion_r771046685
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -1097,15 +1097,20 @@ long decodeTimestamp(final String encryptedString) {
if (encryptedString.isEmpty()) {
return RecordQueue.UNKNOWN;
}
- final ByteBuffer buffer = ByteBuffer.wrap(Base64.getDecoder().decode(encryptedString));
- final byte version = buffer.get();
- switch (version) {
- case LATEST_MAGIC_BYTE:
- return buffer.getLong();
- default:
- log.warn("Unsupported offset metadata version found. Supported version {}. Found version {}.",
- LATEST_MAGIC_BYTE, version);
- return RecordQueue.UNKNOWN;
+ try {
+ final ByteBuffer buffer = ByteBuffer.wrap(Base64.getDecoder().decode(encryptedString));
+ final byte version = buffer.get();
+ switch (version) {
+ case LATEST_MAGIC_BYTE:
+ return buffer.getLong();
+ default:
+ log.warn("Unsupported offset metadata version found. Supported version {}. Found version {}.",
+ LATEST_MAGIC_BYTE, version);
+ return RecordQueue.UNKNOWN;
+ }
+ } catch (final IllegalArgumentException argumentException) {
+ log.warn("Unsupported offset metadata found {}", encryptedString);
Review comment:
Nit: `log.warn("Could not decode offset metadata.")`
I think it's better not to log `encryptedString` as we don't know what's in it, and we could potentially leak sensitive information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org