[lucene-solr] branch reference_impl updated: #175 - Don't try to register as leader after close.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl by this push:
     new c6cb6ab  #175 - Don't try to register as leader after close.
c6cb6ab is described below

commit c6cb6abda5c176877ef45fc7119142a3b4849f5f
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Wed Jul 15 11:48:45 2020 -0500

    #175 - Don't try to register as leader after close.
---
 .../java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java   | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java b/solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
index b6d96a5..7874166 100644
--- a/solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
+++ b/solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
@@ -123,8 +123,11 @@ class ShardLeaderElectionContextBase extends ElectionContext {
     String parent = Paths.get(leaderPath).getParent().toString();
     List<String> errors = new ArrayList<>();
     try {
+      if (isClosed() || zkClient.isClosed()) {
+        log.info("Bailing on becoming leader, we are closed");
+        return;
+      }
       log.info("Creating leader registration node {} after winning as {}", leaderPath, leaderSeqPath);
-      //zkClient.printLayout();
       List<Op> ops = new ArrayList<>(3);
 
       // We use a multi operation to get the parent nodes version, which will