You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/16 04:01:35 UTC

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3883: [Enhancement] Add FORWARD_NO_SYNC for all SHOW PROC statements

kangkaisen commented on a change in pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#discussion_r440572972



##########
File path: fe/src/main/java/org/apache/doris/analysis/ShowProcStmt.java
##########
@@ -82,10 +82,6 @@ public ShowResultSetMetaData getMetaData() {
 
     @Override
     public RedirectStatus getRedirectStatus() {

Review comment:
       I think rename the `forward_to_master` to `show_stmt_forward_to_master`, and change the default value to true is a better way.
   
   **All show stmt should have the consistent behavior.**




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org