You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2015/12/04 16:08:52 UTC
Re: Image based on external url model object
unfortunately I was unable to test it or participate in discussion :(
will try it in next available snapshot :)
On Tue, Dec 1, 2015 at 2:17 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:
> Hi Martin :-D,
>
> and here it is:
>
> https://github.com/apache/wicket/pull/143
>
> kind regards
>
> Tobias
>
> Am 30.11.15 um 21:00 schrieb Martin Grigorov:
>
> Hi,
>>
>> On Nov 30, 2015 4:21 PM, "Sebastien" <se...@gmail.com> wrote:
>>
>>> Hi Tobias,
>>>
>>> As I stated, I would prefer 2 different models so :
>>> - the main model is used for "src"
>>> - the model is not itself an array of models (I don't recall there is a
>>> such case elsewhere in Wicket)
>>> - it is easier to handle the CPM case
>>>
>>> As the other devs are now back from week-end, it would be nice to have
>>>
>> some
>>
>>> other opinions! :)
>>>
>> I usually wait for the PR to be able to comment on the changes.
>>
>>
>>>
>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/image/ExternalImage.java
>>
>> There is no commenting functionality in such links.
>>
>> I could comment on the original commits but:
>> 1) I have to find them
>> 2) no one else (but Tobias) will see my comments
>>
>> Thanks & best regards,
>>> Sebastien.
>>>
>>>
>>> On Sat, Nov 28, 2015 at 8:10 AM, Tobias Soloschenko <
>>> tobiassoloschenko@googlemail.com> wrote:
>>>
>>> Hi Sebastien,
>>>>
>>>> thanks for testing :-)
>>>>
>>>> I thought it would be nice to get all models by the default WebComponent
>>>> method and that they are all stored as defaultmodelobject.
>>>>
>>>> WDTY?
>>>>
>>>> Anyway it would safe 2 methods.
>>>>
>>>> kind regards
>>>>
>>>> Tobias
>>>>
>>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
--
WBR
Maxim aka solomax
Re: Image based on external url model object
Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Maxim,
it should be available within the next SNAPSHOT. I pushed the
corresponding commits to master and to wicket-7.x, now.
ExternalImage and ExternalSource.
Here are some examples:
https://github.com/apache/wicket/blob/master/wicket-core/src/test/java/org/apache/wicket/markup/html/image/ExternalImageTestPage.java
kind regards
Tobias
Am 04.12.15 um 16:08 schrieb Maxim Solodovnik:
> unfortunately I was unable to test it or participate in discussion :(
> will try it in next available snapshot :)
>
> On Tue, Dec 1, 2015 at 2:17 AM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
>> Hi Martin :-D,
>>
>> and here it is:
>>
>> https://github.com/apache/wicket/pull/143
>>
>> kind regards
>>
>> Tobias
>>
>> Am 30.11.15 um 21:00 schrieb Martin Grigorov:
>>
>> Hi,
>>> On Nov 30, 2015 4:21 PM, "Sebastien" <se...@gmail.com> wrote:
>>>
>>>> Hi Tobias,
>>>>
>>>> As I stated, I would prefer 2 different models so :
>>>> - the main model is used for "src"
>>>> - the model is not itself an array of models (I don't recall there is a
>>>> such case elsewhere in Wicket)
>>>> - it is easier to handle the CPM case
>>>>
>>>> As the other devs are now back from week-end, it would be nice to have
>>>>
>>> some
>>>
>>>> other opinions! :)
>>>>
>>> I usually wait for the PR to be able to comment on the changes.
>>>
>>>
>>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/image/ExternalImage.java
>>>
>>> There is no commenting functionality in such links.
>>>
>>> I could comment on the original commits but:
>>> 1) I have to find them
>>> 2) no one else (but Tobias) will see my comments
>>>
>>> Thanks & best regards,
>>>> Sebastien.
>>>>
>>>>
>>>> On Sat, Nov 28, 2015 at 8:10 AM, Tobias Soloschenko <
>>>> tobiassoloschenko@googlemail.com> wrote:
>>>>
>>>> Hi Sebastien,
>>>>> thanks for testing :-)
>>>>>
>>>>> I thought it would be nice to get all models by the default WebComponent
>>>>> method and that they are all stored as defaultmodelobject.
>>>>>
>>>>> WDTY?
>>>>>
>>>>> Anyway it would safe 2 methods.
>>>>>
>>>>> kind regards
>>>>>
>>>>> Tobias
>>>>>
>>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org