Re: [PR] Test suite fixes [activemq-artemis]

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on code in PR #5346:
URL: https://github.com/apache/activemq-artemis/pull/5346#discussion_r1842645654


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java:
##########
@@ -346,6 +346,7 @@ public void onMessageComplete(Delivery delivery,
       connection.requireInHandler();
 
       try {
+         this.messageReader.close();

Review Comment:
   Can you elaborate the actual issue and how this close moving here makes a difference? Looking at the large message reader, its close method, and how/when the reader calls this onMessageComplete() method, I'm not really seeing how this would alter the behaviour to fix something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact