You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Julian Sedding (Jira)" <ji...@apache.org> on 2021/06/24 20:10:00 UTC

[jira] [Resolved] (SLING-10549) Regression: BundleTestsProvider recognizes too many test-classes

     [ https://issues.apache.org/jira/browse/SLING-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Sedding resolved SLING-10549.
------------------------------------
    Resolution: Fixed

Fixed with [commit dcbc298|https://github.com/apache/sling-org-apache-sling-junit-core/commit/dcbc2989bcd956b4f54fb45520505e08a69d6951].

> Regression: BundleTestsProvider recognizes too many test-classes
> ----------------------------------------------------------------
>
>                 Key: SLING-10549
>                 URL: https://issues.apache.org/jira/browse/SLING-10549
>             Project: Sling
>          Issue Type: Bug
>          Components: JUnit Core, Testing
>    Affects Versions: JUnit Core 1.1.0
>            Reporter: Julian Sedding
>            Assignee: Julian Sedding
>            Priority: Minor
>             Fix For: JUnit Core 1.1.6
>
>
> The {{BundleTestsProvider}} is responsible for evaluating the {{Sling-Test-Regexp}}. With version 1.1.0 a regression was introduced by refactoring from 
> bq. {{Pattern.compile(headerValue).matcher(testName).matches()}}
> to
> bq. {{Pattern.compile(headerValue).asPredicate().test(testName)}}
> This is equivalent to calling {{Pattern.compile(headerValue).matcher(testName).find()}}, which returns true on partial matches, while {{#matches()}} only returns true for complete matches.
> We should revert to the previous behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)