You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/13 08:18:55 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #3340: Optimize bulk writing of all blocks of bloom filter
viirya opened a new pull request, #3340:
URL: https://github.com/apache/arrow-rs/pull/3340
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #3320.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
```
write_batch primitive/4096 values primitive with bloom filter
time: [4.2750 ms 4.2905 ms 4.3059 ms]
thrpt: [40.995 MiB/s 41.143 MiB/s 41.291 MiB/s]
change:
time: [-18.394% -16.070% -13.847%] (p = 0.00 < 0.05)
thrpt: [+16.072% +19.147% +22.541%]
Performance has improved.
write_batch primitive/4096 values primitive non-null with bloom filter
time: [4.4500 ms 4.5848 ms 4.7319 ms]
thrpt: [36.582 MiB/s 37.756 MiB/s 38.900 MiB/s]
change:
time: [-21.355% -17.148% -12.445%] (p = 0.00 < 0.05)
thrpt: [+14.214% +20.697% +27.153%]
Performance has improved.
write_batch primitive/4096 values string with bloom filter
time: [945.94 µs 946.62 µs 947.37 µs]
thrpt: [84.060 MiB/s 84.126 MiB/s 84.186 MiB/s]
change:
time: [-26.414% -25.196% -23.997%] (p = 0.00 < 0.05)
thrpt: [+31.573% +33.682% +35.895%]
Performance has improved.
write_batch primitive/4096 values string dictionary with bloom filter
time: [494.68 µs 495.13 µs 495.60 µs]
thrpt: [97.137 MiB/s 97.230 MiB/s 97.318 MiB/s]
change:
time: [-19.467% -18.637% -17.900%] (p = 0.00 < 0.05)
thrpt: [+21.803% +22.905% +24.173%]
Performance has improved.
write_batch primitive/4096 values string non-null with bloom filter
time: [1.0266 ms 1.0275 ms 1.0284 ms]
thrpt: [76.484 MiB/s 76.553 MiB/s 76.618 MiB/s]
change:
time: [-28.422% -28.120% -27.852%] (p = 0.00 < 0.05)
thrpt: [+38.604% +39.121% +39.709%]
Performance has improved.
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #3340: Optimize bulk writing of all blocks of bloom filter
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #3340:
URL: https://github.com/apache/arrow-rs/pull/3340#issuecomment-1349495872
Yea, seems other parts of the parquet writer could have benefit from BufWriter if we can add it higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3340: Optimize bulk writing of all blocks of bloom filter
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3340:
URL: https://github.com/apache/arrow-rs/pull/3340#issuecomment-1349634719
Benchmark runs are scheduled for baseline = 46b2848596216afc3bb09882b7004dbf1add57ed and contender = 2749dcca50e6dd0ac72db7fe802552c2db742c3c. 2749dcca50e6dd0ac72db7fe802552c2db742c3c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/650ae96f5bf84f7dbe4e6a77449400f8...d6e54744fec2465c8f7edc289df66d88/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5989ac0c83774b2ca775d1365f3cfaad...4f630ac4883c45728ae791626ae86b6b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e521b3e7cc3d4e13b0bbd190ce870ec6...aa007944a53247688d96958778c5cff5/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/df9b7b627ecd41018d7377f6e065783a...dd0cd90d482648aba54564adc47a59d2/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3340: Optimize bulk writing of all blocks of bloom filter
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3340:
URL: https://github.com/apache/arrow-rs/pull/3340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org