You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/07 01:31:10 UTC

[GitHub] [spark] yikf commented on a change in pull request #31015: [SPARK-33991][CORE]Repair enumeration conversion error for AllJobsPage.

yikf commented on a change in pull request #31015:
URL: https://github.com/apache/spark/pull/31015#discussion_r553058804



##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -279,13 +289,14 @@ private[ui] class AllJobsPage(parent: JobsTab, store: AppStatusStore) extends We
 
     val schedulingMode = store.environmentInfo().sparkProperties.toMap

Review comment:
       Hi @sarutak ,Thanks for reviewin，I see your thoughts, I will add the test to `UISeleniumSuite` and  replace this duplicated code with the method call of `getSchedulingMode()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org