You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/01/12 20:08:59 UTC
[kudu-CR](branch-1.2.x) Doc review for 1.2
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5693
Change subject: Doc review for 1.2
......................................................................
Doc review for 1.2
I made a pass through all of the documentation and made improvements as
necessary for 1.2:
* Specify that the start/stop instructions are deb/rpm specific
* Updated the contribution C++ style guide to stop talking about
gscoped_ptr
* Removed limitation that Spark is only for Spark 1 (now we support
Spark 2)
* Fixed some branding in index.adoc
* Some small tweaks and improvements to the glossary of concepts
The larger changes are in the Impala integration. I tried to update the
syntax and examples to match the Impala-Kudu release from 11/22/2016
(the most recent release at the time of this writing and at the expected
release date for Kudu 1.2). Unfortunately, the syntax and capabilities
have changed again between that release and the upcoming Impala 2.8
release. Rather than document the unreleased syntax, I went with the
soon-to-be-removed syntax.
Similarly, I left in all of the instructions about how to install the
Impala-Kudu fork, even though that fork has now been merged back into
the main Impala release train. When Impala 2.8 is available, we will
have to do another pass here and re-publish docs.
Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb
Reviewed-on: http://gerrit.cloudera.org:8080/5676
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 2505094c698c5a74fafde5f1d1ee6cd489ce836b)
---
M docs/administration.adoc
M docs/contributing.adoc
M docs/developing.adoc
M docs/index.adoc
M docs/kudu_impala_integration.adoc
5 files changed, 145 insertions(+), 259 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5693/1
--
To view, visit http://gerrit.cloudera.org:8080/5693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.2.x) Doc review for 1.2
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Doc review for 1.2
......................................................................
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) Doc review for 1.2
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Doc review for 1.2
......................................................................
Doc review for 1.2
I made a pass through all of the documentation and made improvements as
necessary for 1.2:
* Specify that the start/stop instructions are deb/rpm specific
* Updated the contribution C++ style guide to stop talking about
gscoped_ptr
* Removed limitation that Spark is only for Spark 1 (now we support
Spark 2)
* Fixed some branding in index.adoc
* Some small tweaks and improvements to the glossary of concepts
The larger changes are in the Impala integration. I tried to update the
syntax and examples to match the Impala-Kudu release from 11/22/2016
(the most recent release at the time of this writing and at the expected
release date for Kudu 1.2). Unfortunately, the syntax and capabilities
have changed again between that release and the upcoming Impala 2.8
release. Rather than document the unreleased syntax, I went with the
soon-to-be-removed syntax.
Similarly, I left in all of the instructions about how to install the
Impala-Kudu fork, even though that fork has now been merged back into
the main Impala release train. When Impala 2.8 is available, we will
have to do another pass here and re-publish docs.
Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb
Reviewed-on: http://gerrit.cloudera.org:8080/5676
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 2505094c698c5a74fafde5f1d1ee6cd489ce836b)
Reviewed-on: http://gerrit.cloudera.org:8080/5693
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M docs/administration.adoc
M docs/contributing.adoc
M docs/developing.adoc
M docs/index.adoc
M docs/kudu_impala_integration.adoc
5 files changed, 145 insertions(+), 259 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64ad4925ba4402ef3733a0ab62da91f1049848fb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>