You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DrIgor <gi...@git.apache.org> on 2017/01/25 08:47:43 UTC
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
GitHub user DrIgor opened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-921
### How should this be tested?
Build zeppelin with R profile enabled and run several R snippets
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1946
----
commit b1dd6a33040b17be7cd52a8c482062453a00ed44
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-23T11:20:38Z
Search for interpreter-settings in several jars in folder
commit b264c9fff7ea2f721b64eab31fae9abf7c9ba107
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-25T08:36:53Z
New registration mechanism for R interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1946
Rebased on master and ran build.
I tried several times:
- https://travis-ci.org/apache/zeppelin/builds/197341657
- https://travis-ci.org/apache/zeppelin/builds/197539698
- https://travis-ci.org/apache/zeppelin/builds/197547341
CI is still red, but every time it had a different failure. I think they are not caused by my changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1946
@jongyoul sorry for late response!
I checked failure. It's related to PR but I don't know how to fix it
Build profile uses
```
$ export SCALA_VER="2.11"
$ export SPARK_VER="1.6.3"
```
`downloadSpark.sh` downloads spark prebuilt for scala 2.10. So we have incompatible versions of scala.
I tried to build spark 1.6 with scala 2.11 \u2014 R interpreter works fine. But spark does not provide such binary distribution.
Does Zeppelin support spark 1.6 with scala 2.11? Then we should provide binary spark distribution for this build profile. I think it affects not only R interpreter
This code https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java#L152 exclude R interpreter during tests. But it doesn't work with new registration mechanist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1946
@DrIgor The last failures looks related to this PR. Can you check it?
- https://api.travis-ci.org/jobs/197657609/log.txt?deansi=true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-921
### How should this be tested?
Build zeppelin with R profile enabled and run several R snippets
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1946
----
commit a76a41d7dd538eb47522d6bf53e7aecdf65f3829
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-25T08:36:53Z
New registration mechanism for R interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:
https://github.com/apache/zeppelin/pull/1946
Needs this changes: #1937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1946
Thanks for checking it. As you mentioned, we removed those kind of tests but we should take care of it because we couldn't break to install any of modules. Your comment makes sense to me and thank you for letting me know the scala version issue between them. LGTM and I'll merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1946
I merged #1937. Can you rebase it onto master and make CI green?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-921
### How should this be tested?
Build zeppelin with R profile enabled and run several R snippets
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1946
----
commit a76a41d7dd538eb47522d6bf53e7aecdf65f3829
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-25T08:36:53Z
New registration mechanism for R interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1946: [ZEPPELIN-921] Apply new mechanism to KnitR and...
Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:
https://github.com/apache/zeppelin/pull/1946
[ZEPPELIN-921] Apply new mechanism to KnitR and RRepl
### What is this PR for?
Applies new registration mechanism for R interpreter
### What type of PR is it?
[Refactoring]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-921
### How should this be tested?
Build zeppelin with R profile enabled and run several R snippets
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-921
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1946
----
commit a76a41d7dd538eb47522d6bf53e7aecdf65f3829
Author: Igor Drozdov <ig...@epam.com>
Date: 2017-01-25T08:36:53Z
New registration mechanism for R interpreter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---