You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by akedin <gi...@git.apache.org> on 2017/11/10 01:25:13 UTC
[GitHub] beam pull request #4110: [BEAM-3147] Nexmark launcher refactor
GitHub user akedin opened a pull request:
https://github.com/apache/beam/pull/4110
[BEAM-3147] Nexmark launcher refactor
Refactoring Nexmark launcher. Goal is to make it more modular and extensible to simplify [SQL integration](https://issues.apache.org/jira/browse/BEAM-3147). This PR mostly takes pieces out of NexmarkLauncher, like sinks or event sources, into their own PTransforms.
This version runs as expected in batch mode on direct runner. Working on testing other modes.
Currently this PR also includes commits from the [previous PR](https://github.com/apache/beam/pull/4087).
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akedin/beam nexmark-launcher-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4110
----
commit 2b2afd454f584d7995ef87796ae2a37b3431739c
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T22:47:38Z
[Nexmark] Extract GeneratorCheckpoint into a separate class. Move getNextEvent() call to the top of the stack.
commit 8792a19e3bc2bf88ce9e23fab49199f74a3c00d7
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T23:01:58Z
[Nexmark] Extract PersonGenerator, StringsGenerator, LongGenerator from Generator
commit 7aca5453281b27c292334575e6b9e6527c9c2add
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T23:12:53Z
[Nexmark] Extract AuctionGenerator, PriceGenerator from Generator
commit 2a5c7390b25027947e5bd618026a06d542e53f21
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-06T23:19:39Z
[Nexmark] Extract BidGenerator from Generator
commit c483f1fdf24d712878ab0e49f06299df625c1527
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-07T04:39:10Z
fixup! [Nexmark] Extract BidGenerator from Generator
commit 7b25d2ed5e21ae4135cf0615c8616a57eddfa6f6
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-07T21:44:58Z
[BEAM-3147][NexmarkLauncher] Extract EventSourceFactory and Event sources out from NexmarkLauncher
Refactoring to make the launcher smaller.
commit 39cd3170fb5dbd88b4f5bf9066605a63e7efe341
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-08T18:58:16Z
[BEAM-3147][NexmarkLauncher] Move results Sinks out from NexmarkLauncher
Refactoring to make NexmarkLauncher smaller
commit 61bda79718df3563f7a5e15e58103a534e6dd370
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-08T21:11:20Z
[BEAM-3147][NexmarkLauncher] Extract NexmarkPerfAnalyzer out of NexmarkLauncher
Refactor to make NexmarkLauncher smaller
commit db89bdaca5ec9af98acc9f27feffc2cb3243db8c
Author: Anton Kedin <ke...@google.com>
Date: 2017-11-08T21:30:25Z
[BEAM-3147][NexmarkLauncher] Move NexmarkQuery creation out of NexmarkLauncher
Refactor to make NexmarkLauncher smaller
----
---