You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/16 02:06:17 UTC
[GitHub] [iceberg] jackye1995 opened a new pull request #2832: Doc: add link to PrestoDB support
jackye1995 opened a new pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832
GIven the fact that now PrestoDB also supports Iceberg, updating the tabs and links to reflect this. @yyanyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 closed pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 closed pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672659611
##########
File path: site/docs/index.md
##########
@@ -20,7 +20,7 @@
# 
-**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to Trino and Spark that use a high-performance format that works just like a SQL table.
+**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to compute engines including Spark, Trino, PrestoDB, Flink and Hive using a high-performance format that works just like a SQL table.
Review comment:
I think that some version of this update would be good. Mentioning support in Flink, Hive, and PrestoDB in addition to Spark is a good idea and doesn't affect the Trino documentation.
##########
File path: site/mkdocs.yml
##########
@@ -72,7 +72,9 @@ nav:
- Maintenance Procedures: spark-procedures.md
- Structured Streaming: spark-structured-streaming.md
- Time Travel: spark-queries/#time-travel
- - Trino: https://trino.io/docs/current/connector/iceberg.html
+ - Presto:
+ - Trino (PrestoSQL): https://trino.io/docs/current/connector/iceberg.html
+ - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
Review comment:
Hm, I'm wondering how we want to handle this. There should be more and more engines with Iceberg support and we don't want to keep adding tabs for each one. Maybe there's room for PrestoDB? Or maybe we should fix the problem now and have a page for documentation that is hosted elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#issuecomment-882766900
@electrum thanks for the confirmation! I will close this PR and put up another one that tries to refactor the current tabs to accommodate more engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#issuecomment-882766900
@electrum thanks for the confirmation! I will close this PR and put up another one that tries to refactor the current tabs to accommodate more engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#issuecomment-881651538
@electrum @rdblue
not sure if this categorization would have any legal issue, or if Trino community is happy with. I was thinking these are Presto-flavor engines, and most people still consider them as very similar "Presto" engines at least from user perspective, thus the `Presto` tab.
and as there are more engine joining, another approach we can go is to:
1. continue to have Spark as the reference engine implementation with its separated tab
2. for all the other engine,s to have an `Engines` tab, which can nest all the different engines which also moves `Flink` and `Hive` under that category.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672705481
##########
File path: site/mkdocs.yml
##########
@@ -72,7 +72,9 @@ nav:
- Maintenance Procedures: spark-procedures.md
- Structured Streaming: spark-structured-streaming.md
- Time Travel: spark-queries/#time-travel
- - Trino: https://trino.io/docs/current/connector/iceberg.html
+ - Presto:
+ - Trino (PrestoSQL): https://trino.io/docs/current/connector/iceberg.html
+ - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
Review comment:
Yes, I think we need to find a better way in organizing tabs. I am putting up a new PR, we can discuss there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 closed pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 closed pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672659611
##########
File path: site/docs/index.md
##########
@@ -20,7 +20,7 @@
# 
-**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to Trino and Spark that use a high-performance format that works just like a SQL table.
+**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to compute engines including Spark, Trino, PrestoDB, Flink and Hive using a high-performance format that works just like a SQL table.
Review comment:
I think that some version of this update would be good. Mentioning support in Flink, Hive, and PrestoDB in addition to Spark is a good idea and doesn't affect the Trino documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] electrum commented on pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
electrum commented on pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#issuecomment-881873529
I object to this change. Trino is not Presto, a flavor of Presto, etc., nor is “PrestoSQL” an alternate name for Trino. It is a separate project, forked 2.5 years ago, with continued divergence. The current language on the page is correct.
Further, I believe this would violate the Presto trademark, which is owned by the Linux Foundation and is actively enforced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#issuecomment-882766900
@electrum thanks for the confirmation! I will close this PR and put up another one that tries to refactor the current tabs to accommodate more engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672705481
##########
File path: site/mkdocs.yml
##########
@@ -72,7 +72,9 @@ nav:
- Maintenance Procedures: spark-procedures.md
- Structured Streaming: spark-structured-streaming.md
- Time Travel: spark-queries/#time-travel
- - Trino: https://trino.io/docs/current/connector/iceberg.html
+ - Presto:
+ - Trino (PrestoSQL): https://trino.io/docs/current/connector/iceberg.html
+ - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
Review comment:
Yes, I think we need to find a better way in organizing tabs. I am putting up a new PR, we can discuss there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672659611
##########
File path: site/docs/index.md
##########
@@ -20,7 +20,7 @@
# 
-**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to Trino and Spark that use a high-performance format that works just like a SQL table.
+**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg adds tables to compute engines including Spark, Trino, PrestoDB, Flink and Hive using a high-performance format that works just like a SQL table.
Review comment:
I think that some version of this update would be good. Mentioning support in Flink, Hive, and PrestoDB in addition to Spark is a good idea and doesn't affect the Trino documentation.
##########
File path: site/mkdocs.yml
##########
@@ -72,7 +72,9 @@ nav:
- Maintenance Procedures: spark-procedures.md
- Structured Streaming: spark-structured-streaming.md
- Time Travel: spark-queries/#time-travel
- - Trino: https://trino.io/docs/current/connector/iceberg.html
+ - Presto:
+ - Trino (PrestoSQL): https://trino.io/docs/current/connector/iceberg.html
+ - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
Review comment:
Hm, I'm wondering how we want to handle this. There should be more and more engines with Iceberg support and we don't want to keep adding tabs for each one. Maybe there's room for PrestoDB? Or maybe we should fix the problem now and have a page for documentation that is hosted elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XuQianJin-Stars commented on pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#issuecomment-881835880
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672660673
##########
File path: site/mkdocs.yml
##########
@@ -72,7 +72,9 @@ nav:
- Maintenance Procedures: spark-procedures.md
- Structured Streaming: spark-structured-streaming.md
- Time Travel: spark-queries/#time-travel
- - Trino: https://trino.io/docs/current/connector/iceberg.html
+ - Presto:
+ - Trino (PrestoSQL): https://trino.io/docs/current/connector/iceberg.html
+ - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
Review comment:
Hm, I'm wondering how we want to handle this. There should be more and more engines with Iceberg support and we don't want to keep adding tabs for each one. Maybe there's room for PrestoDB? Or maybe we should fix the problem now and have a page for documentation that is hosted elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 closed pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 closed pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a change in pull request #2832: Doc: add link to PrestoDB support
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #2832:
URL: https://github.com/apache/iceberg/pull/2832#discussion_r672705481
##########
File path: site/mkdocs.yml
##########
@@ -72,7 +72,9 @@ nav:
- Maintenance Procedures: spark-procedures.md
- Structured Streaming: spark-structured-streaming.md
- Time Travel: spark-queries/#time-travel
- - Trino: https://trino.io/docs/current/connector/iceberg.html
+ - Presto:
+ - Trino (PrestoSQL): https://trino.io/docs/current/connector/iceberg.html
+ - PrestoDB: https://prestodb.io/docs/current/connector/iceberg.html
Review comment:
Yes, I think we need to find a better way in organizing tabs. I am putting up a new PR, we can discuss there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org