You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/05 10:29:26 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #701: feat: deploy with docker

juzhiyuan opened a new pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   Deploy the dashboard with Docker (demo site support)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan merged pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-724413816


   OK then let's merge it now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen edited a comment on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-724413455


   Dockerfile in `./api` had been removed into `api/test/docker`:
   https://github.com/apache/apisix-dashboard/pull/753
   
   I think there is nothing confusing about Dockerfile now.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-722292181


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=h1) Report
   > Merging [#701](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=desc) into [v2.0](https://codecov.io/gh/apache/apisix-dashboard/commit/3a405f779c0d65ca68e52a9745662aca4272ecc1?el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/701/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##             v2.0     #701      +/-   ##
   ==========================================
   + Coverage   43.08%   43.16%   +0.08%     
   ==========================================
     Files          18       18              
     Lines        1237     1237              
   ==========================================
   + Hits          533      534       +1     
   + Misses        615      614       -1     
     Partials       89       89              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.94% <0.00%> (+0.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=footer). Last update [3a405f7...28c788d](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-724413455


   Dockerfile in `./api` had remove into `api/test/docker`:
   https://github.com/apache/apisix-dashboard/pull/753
   
   I think there is nothing confusing about Dockerfile now.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io commented on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-722292181


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`v2.0@88a6761`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/701/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##             v2.0     #701   +/-   ##
   =======================================
     Coverage        ?   42.82%           
   =======================================
     Files           ?       18           
     Lines           ?     1212           
     Branches        ?        0           
   =======================================
     Hits            ?      519           
     Misses          ?      605           
     Partials        ?       88           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=footer). Last update [88a6761...5e092c6](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r517948542



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       @nic-chen @gxthrj 
   
   Please take a look at this line, I'm not sure how to deploy in Azure, please help me to complete the rest work, thanks!
   
   NOTE: When running docker with this image, we should mount a [conf file](https://github.com/apache/apisix-dashboard/blob/feat-deploy-with-docker/docs/examples/docker-conf-example.json) just like this line does.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519252864



##########
File path: docs/deploy-with-docker.zh-CN.md
##########
@@ -34,7 +34,7 @@ $ docker build -t apisix-dashboard:{$tag} .
 
 - `conf.listen.host` 为容器内监听 IP,必须为 `0.0.0.0`,这样宿主才能访问容器内网络。
 - `conf.listen.port` 为容器内监听端口,默认为 `8080`。如需修改,请同步修改 [Dockerfile](../Dockerfile)。
-- `conf.etcd.endpoints` 为 ETCD 主机列表,多个节点以**英文逗号**连接,请确保容器可以访问到这些主机,例如:示例配置中 `conf.etcd.endpoints` 为 `host.docker.internal` 旨在允许容器访问宿主主机上的网络。
+- `conf.etcd.endpoints` 为 ETCD 主机列表,支持多多个节点,请确保容器可以访问到这些主机,例如:示例配置中 `conf.etcd.endpoints` 为 `host.docker.internal` 旨在允许容器访问宿主主机上的网络。

Review comment:
       多多????




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519668804



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       now use `docker-conf-example.yaml` instead of `docker-conf-example.json`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519057295



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       will update according the test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] moonming commented on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-723901357


   Where is the dockerfile for user? Looks like all for test and deploy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-723536214


   @gxthrj  please help deploy in Cloud. I don't know how to trigger the hook.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-722292181


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=h1) Report
   > Merging [#701](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=desc) (e1c5671) into [v2.0](https://codecov.io/gh/apache/apisix-dashboard/commit/3a405f779c0d65ca68e52a9745662aca4272ecc1?el=desc) (3a405f7) will **increase** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/701/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##             v2.0     #701      +/-   ##
   ==========================================
   + Coverage   43.08%   43.16%   +0.08%     
   ==========================================
     Files          18       18              
     Lines        1237     1237              
   ==========================================
   + Hits          533      534       +1     
   + Misses        615      614       -1     
     Partials       89       89              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/701/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.94% <0.00%> (+0.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=footer). Last update [3a405f7...e1c5671](https://codecov.io/gh/apache/apisix-dashboard/pull/701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519261267



##########
File path: docs/deploy-with-docker.zh-CN.md
##########
@@ -34,7 +34,7 @@ $ docker build -t apisix-dashboard:{$tag} .
 
 - `conf.listen.host` 为容器内监听 IP,必须为 `0.0.0.0`,这样宿主才能访问容器内网络。
 - `conf.listen.port` 为容器内监听端口,默认为 `8080`。如需修改,请同步修改 [Dockerfile](../Dockerfile)。
-- `conf.etcd.endpoints` 为 ETCD 主机列表,多个节点以**英文逗号**连接,请确保容器可以访问到这些主机,例如:示例配置中 `conf.etcd.endpoints` 为 `host.docker.internal` 旨在允许容器访问宿主主机上的网络。
+- `conf.etcd.endpoints` 为 ETCD 主机列表,支持多多个节点,请确保容器可以访问到这些主机,例如:示例配置中 `conf.etcd.endpoints` 为 `host.docker.internal` 旨在允许容器访问宿主主机上的网络。

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r518635837



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       sure, let's fix this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519668804



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       now use `docker-conf-example.yaml` instead of `docker-conf-example.json`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#issuecomment-724037639


   any update? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r517948542



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       @nic-chen @gxthrj 
   
   Please take a look at this line, I'm not sure how to deploy in Azure, please help me to complete the rest work, thanks!
   
   NOTE: When running docker with this image, we should mount a conf file just like this line does.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r517959053



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       Error:
   
   https://github.com/apache/apisix-dashboard/pull/701/checks?check_run_id=1357706148#step:5:976




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r518843378



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       And please update the related docs, thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #701: feat: deploy with docker

Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #701:
URL: https://github.com/apache/apisix-dashboard/pull/701#discussion_r519688400



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -0,0 +1,40 @@
+name: Deploy with Docker
+
+on:
+  push:
+    branches:
+      - master
+      - v2.0
+  pull_request:
+    branches:
+      - master
+      # NOTE: Just to trigger CD in this PR, will be removed before being merged
+      - v2.0
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    services:
+      etcd:
+        image: bitnami/etcd:3.3.13-r80
+        ports:
+          - 2379:2379
+          - 2380:2380
+        env:
+          ALLOW_NONE_AUTHENTICATION: yes
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: Azure/docker-login@v1
+        with:
+          login-server: apisixacr.azurecr.cn
+          username: ${{ secrets.REGISTRY_USERNAME }}
+          password: ${{ secrets.REGISTRY_PASSWORD }}
+
+      - name: Build then Deploy
+        run: |
+          docker build -t apisixacr.azurecr.cn/dashboard:${{ github.sha }} .
+          docker push apisixacr.azurecr.cn/dashboard:${{ github.sha }}
+          docker run -d -p 80:8080 -v ${pwd}/docs/examples/docker-conf-example.json:/usr/local/apisix-dashboard/conf/conf.json apisixacr.azurecr.cn/dashboard:${{ github.sha }}

Review comment:
       it works now
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org