You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2020/10/02 13:13:00 UTC

[jira] [Comment Edited] (CASSANDRA-16121) Circleci should run cqlshlib tests as well

    [ https://issues.apache.org/jira/browse/CASSANDRA-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206155#comment-17206155 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-16121 at 10/2/20, 1:12 PM:
---------------------------------------------------------------------------

Thank you for your work.

One last thing to add and I will +1. Artifacts are not stored.

Otherwise I apply the patch and the only thing I see is this line but the patch applies properly so it doesn't look as an issue?
{code:java}
missing header for unified diff at line 1 of patch{code}
Also, [~Bereng], you mentioned this line doesn't appear on your machine...

[~dcapwell], can you also check it, please?


was (Author: e.dimitrova):
Thank you for your work.

One last thing to add and I will +1. Artifacts are not stored.

Otherwise I apply the patch and the only thing I see is this line but the patch applies properly so it doesn't look as an issue?
{code:java}
missing header for unified diff at line 1 of patch{code}
Also you mentioned this line doesn't appear on your machine...

[~dcapwell], can you also check it, please?

> Circleci should run cqlshlib tests as well
> ------------------------------------------
>
>                 Key: CASSANDRA-16121
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16121
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI, Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0-beta, 4.0-triage
>
>
> Currently circleci is not running cqlshlib tests. This resulted in some bugs not being caught before committing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org