[GitHub] [daffodil] tuxji commented on a diff in pull request #1037: Allows include/import schemaLocations to have relative up path steps.

["tuxji (via GitHub)" <gi...@apache.org>]

tuxji commented on code in PR #1037:
URL: https://github.com/apache/daffodil/pull/1037#discussion_r1240415230


##########
daffodil-test/src/test/resources/test space/test 1/multi_base_05_nons.dfdl.xsd:
##########
@@ -28,8 +28,9 @@
         alignment="implicit" alignmentUnits="bytes" trailingSkip="0"/>
     </xs:appinfo>
   </xs:annotation>
-   
-  <xs:include schemaLocation="test space/test 2/multi_A_05_nons.dfdl.xsd"/>
+
+  <!-- schemaLocations can either be relative paths, or can be absolute paths -->
+  <xs:include schemaLocation="../../test space/test 2/multi_A_05_nons.dfdl.xsd"/>

Review Comment:
   Makes sense to me.  I like the simpler rules making relative paths always look at the file system (except for an org/apache/daffodil heuristic if necessary) and absolute paths always look at the classpath.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org