You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/10/25 02:29:18 UTC
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1045: add log for location issue #435
peacewong commented on a change in pull request #1045:
URL: https://github.com/apache/incubator-linkis/pull/1045#discussion_r735219325
##########
File path: linkis-computation-governance/linkis-engineconn/linkis-engineconn-executor/callback-service/src/main/scala/org/apache/linkis/engineconn/callback/service/EngineConnCallback.scala
##########
@@ -28,14 +31,21 @@ trait EngineConnCallback {
}
-abstract class AbstractEngineConnStartUpCallback(emInstance: ServiceInstance) extends EngineConnCallback {
+abstract class AbstractEngineConnStartUpCallback(emInstance: ServiceInstance) extends EngineConnCallback with Logging{
override protected def getEMSender: Sender = {
Sender.getSender(emInstance)
}
def callback(protocol: RequestProtocol): Unit = {
+ if(protocol.isInstanceOf[EngineConnStatusCallback]){
+ if(protocol.asInstanceOf[EngineConnStatusCallback].status.equals(NodeStatus.Failed)){
Review comment:
It is recommended to replace it with pattern matching(match case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org