You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/12 07:11:07 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24035: feat: implement time grain in temporal filters
codecov[bot] commented on PR #24035:
URL: https://github.com/apache/superset/pull/24035#issuecomment-1545282822
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24035?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24035](https://app.codecov.io/gh/apache/superset/pull/24035?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dde4d9d) into [master](https://app.codecov.io/gh/apache/superset/commit/7fe0ca12c0ae24c9b2546118e9ebdb94a9e3a22d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fe0ca1) will **decrease** coverage by `11.38%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head dde4d9d differs from pull request most recent head 1a5c7bd. Consider uploading reports for the commit 1a5c7bd to get more accurate results
```diff
@@ Coverage Diff @@
## master #24035 +/- ##
===========================================
- Coverage 68.21% 56.84% -11.38%
===========================================
Files 1941 1941
Lines 75259 75259
Branches 8168 8168
===========================================
- Hits 51341 42782 -8559
- Misses 21829 30388 +8559
Partials 2089 2089
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.10% <100.00%> (ø)` | |
| python | `59.31% <100.00%> (-23.47%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.05% <0.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24035?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://app.codecov.io/gh/apache/superset/pull/24035?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `61.48% <100.00%> (-7.83%)` | :arrow_down: |
... and [307 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24035/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org