[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9593: Re-enable table filter, fix #8273 #8683

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #9593:
URL: https://github.com/apache/incubator-superset/pull/9593#issuecomment-617449175


   - when remove a filter_box from dashboard: Currently dashboard will detect this change in dashboardFilters reducer, and then it update filter scopes, default filters, etc. when user save dashboard changes, all metadata is updated.
   
   - when you use table filter in dashboard_1: 
   1. dashboard_1 owner set default filters and filter scopes for table filter
   2. after some time, the table filter can be changed by owner or someone else, turn off its filter attribute, so it is a regular table, not a filter.
   3. dashboard_1 still use this table as filter, right? because when dashboard loads filters related metadata, for example, default_filters, this slice's id is a filter key.
   
   My suggestion is to enable table (or chart) filter, for backward compatible, but its state should **_not_** be persist into dashboard metadata. For every page load, during initialization dashboard can add these temporary filters into dashboardFilters state. when user trigger filter events from chart, dashboardFilters will handle state changes, so that at this dashboard visit,  these chart filters can work as filter. The difference from filter_box filter is:
   - these chart filters have global scope, (if you want to have a filter with respect to only some tabs/charts, you should create a filter_box)
   - when save dashboard, chart filters' state should not be saved into metadata.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org