You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/27 14:48:56 UTC
[GitHub] [dolphinscheduler] DarkAssassinator opened a new pull request, #12173: [fix#12133] Add override hashCode() when overrides equals(Object)
DarkAssassinator opened a new pull request, #12173:
URL: https://github.com/apache/dolphinscheduler/pull/12173
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
fix #12133
## Brief change log
Just add hashCode()
## Verify this pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #12173: [fix#12133] Add override hashCode() when overrides equals(Object)
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #12173:
URL: https://github.com/apache/dolphinscheduler/pull/12173#issuecomment-1260302075
It’s better to use Lombok to generate these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator closed pull request #12173: [fix#12133] Add override hashCode() when overrides equals(Object)
Posted by GitBox <gi...@apache.org>.
DarkAssassinator closed pull request #12173: [fix#12133] Add override hashCode() when overrides equals(Object)
URL: https://github.com/apache/dolphinscheduler/pull/12173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #12173: [fix#12133] Add override hashCode() when overrides equals(Object)
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #12173:
URL: https://github.com/apache/dolphinscheduler/pull/12173#issuecomment-1262408966
> It’s better to use Lombok to generate these code. When we override the equals method we don't need to override hashCode, unless we need to use hash collection. And when we override hashCode, we must override equals.
agree with u
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #12173: [fix#12133] Add override hashCode() when overrides equals(Object)
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #12173:
URL: https://github.com/apache/dolphinscheduler/pull/12173#issuecomment-1279911953
remove this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org