You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2018/08/23 22:51:25 UTC
[6/6] kudu git commit: Enable iwyu on hms files
Enable iwyu on hms files
Change-Id: I7d4a5b23683b4fbec12fa86c24d997677ee3113a
Reviewed-on: http://gerrit.cloudera.org:8080/11301
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/36187ef6
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/36187ef6
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/36187ef6
Branch: refs/heads/master
Commit: 36187ef62e9fb892ea286af8e9547790a3fd34ba
Parents: a8e3335
Author: Dan Burkert <da...@apache.org>
Authored: Wed Aug 22 15:08:14 2018 -0700
Committer: Dan Burkert <da...@apache.org>
Committed: Thu Aug 23 22:50:44 2018 +0000
----------------------------------------------------------------------
build-support/iwyu.py | 6 ------
src/kudu/hms/hms_catalog.cc | 2 ++
src/kudu/hms/hms_catalog.h | 9 ++-------
src/kudu/hms/hms_client.h | 9 +--------
4 files changed, 5 insertions(+), 21 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/36187ef6/build-support/iwyu.py
----------------------------------------------------------------------
diff --git a/build-support/iwyu.py b/build-support/iwyu.py
index f267d0c..d665421 100755
--- a/build-support/iwyu.py
+++ b/build-support/iwyu.py
@@ -61,12 +61,6 @@ _MUTED_FILES = set([
"src/kudu/common/encoded_key-test.cc",
"src/kudu/common/schema.h",
"src/kudu/experiments/rwlock-perf.cc",
- "src/kudu/hms/hms_catalog.cc",
- "src/kudu/hms/hms_catalog.h",
- "src/kudu/hms/hms_client-test.cc",
- "src/kudu/hms/hms_client.cc",
- "src/kudu/hms/hms_client.h",
- "src/kudu/hms/mini_hms.h",
"src/kudu/master/catalog_manager.cc",
"src/kudu/master/catalog_manager.h",
"src/kudu/rpc/reactor.cc",
http://git-wip-us.apache.org/repos/asf/kudu/blob/36187ef6/src/kudu/hms/hms_catalog.cc
----------------------------------------------------------------------
diff --git a/src/kudu/hms/hms_catalog.cc b/src/kudu/hms/hms_catalog.cc
index ad62513..1b57ccb 100644
--- a/src/kudu/hms/hms_catalog.cc
+++ b/src/kudu/hms/hms_catalog.cc
@@ -20,6 +20,7 @@
#include <algorithm>
#include <functional>
#include <iostream>
+#include <iterator>
#include <map>
#include <string>
#include <type_traits>
@@ -34,6 +35,7 @@
#include "kudu/common/schema.h"
#include "kudu/common/types.h"
#include "kudu/gutil/macros.h"
+#include "kudu/gutil/map-util.h"
#include "kudu/gutil/strings/ascii_ctype.h"
#include "kudu/gutil/strings/charset.h"
#include "kudu/gutil/strings/split.h"
http://git-wip-us.apache.org/repos/asf/kudu/blob/36187ef6/src/kudu/hms/hms_catalog.h
----------------------------------------------------------------------
diff --git a/src/kudu/hms/hms_catalog.h b/src/kudu/hms/hms_catalog.h
index ebb1f41..bb807a1 100644
--- a/src/kudu/hms/hms_catalog.h
+++ b/src/kudu/hms/hms_catalog.h
@@ -25,21 +25,16 @@
#include "kudu/gutil/gscoped_ptr.h"
#include "kudu/gutil/port.h"
+#include "kudu/hms/hive_metastore_types.h"
#include "kudu/hms/hms_client.h"
#include "kudu/util/monotime.h"
#include "kudu/util/net/net_util.h"
#include "kudu/util/status.h"
-class StringPiece;
-
-namespace hive {
-class NotificationEvent;
-class Table;
-}
-
namespace kudu {
class Schema;
+class Slice;
class ThreadPool;
namespace hms {
http://git-wip-us.apache.org/repos/asf/kudu/blob/36187ef6/src/kudu/hms/hms_client.h
----------------------------------------------------------------------
diff --git a/src/kudu/hms/hms_client.h b/src/kudu/hms/hms_client.h
index 82ac324..6c97d1c 100644
--- a/src/kudu/hms/hms_client.h
+++ b/src/kudu/hms/hms_client.h
@@ -23,18 +23,11 @@
#include "kudu/gutil/port.h"
#include "kudu/hms/ThriftHiveMetastore.h"
+#include "kudu/hms/hive_metastore_types.h"
#include "kudu/util/monotime.h"
#include "kudu/util/slice.h"
#include "kudu/util/status.h"
-namespace hive {
-class Database;
-class EnvironmentContext;
-class NotificationEvent;
-class Partition;
-class Table;
-}
-
namespace kudu {
class HostPort;