[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…

[GitBox <gi...@apache.org>]

kimmking commented on a change in pull request #4996: add sharding.transaction.seata.at.enable config to compatible with se…
URL: https://github.com/apache/incubator-shardingsphere/pull/4996#discussion_r399905912
 
 

 ##########
 File path: sharding-transaction/sharding-transaction-base/sharding-transaction-base-seata-at/src/main/java/org/apache/shardingsphere/transaction/base/seata/at/SeataATShardingTransactionManager.java
 ##########
 @@ -47,34 +47,56 @@
     
     private final Map<String, DataSource> dataSourceMap = new HashMap<>();
     
-    private final FileConfiguration configuration = new FileConfiguration("seata.conf");
+    private final String applicationId;
+    
+    private final String transactionServiceGroup;
+    
+    private final boolean enableSeataAT;
+    
+    public SeataATShardingTransactionManager() {
+        FileConfiguration configuration = new FileConfiguration("seata.conf");
+        enableSeataAT = configuration.getBoolean("sharding.transaction.seata.at.enable", true);
 
 Review comment:
   Constant for literal？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services