[GitHub] kioie opened a new pull request #3185: apache/cloudstack#3114

[GitBox <gi...@apache.org>]

kioie opened a new pull request #3185: apache/cloudstack#3114
URL: https://github.com/apache/cloudstack/pull/3185
 
 
   Signed-off-by: kioie <ki...@google.com>
   
   ## Description
   <!--- Describe your changes in detail -->
   Referencing this issue: https://github.com/apache/cloudstack/issues/3114
   Edited the code to check for an ipOverlap in the IP ranges and not subnet overlap.
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   **STEPS TO TEST**
   
   `create vlaniprange zoneId="06e5e428-1170-4ab3-bfc3-c018660bdca1" vlan=untagged gateway=192.168.2.1 netmask=255.255.255.0 startip=192.168.2.2 endip=192.168.2.200 forsystemvms=false forVirtualNetwork=true`
   
   `create vlaniprange zoneId="06e5e428-1170-4ab3-bfc3-c018660bdca1" vlan=untagged gateway=192.168.2.1 netmask=255.255.255.0 startip=192.168.2.201 endip=192.168.2.220 forsystemvms=false forVirtualNetwork=true`
   
   **EXPECTED RESULTS**
   `2nd range added without issue`
   
   **ACTUAL RESULTS**
   `2nd range added without issue`
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services