You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/01/10 03:05:54 UTC

Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/
-----------------------------------------------------------

Review request for oozie, Mohammad Islam and Angelo K. Huang.


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-651


This addresses bug OOZIE-651.
    https://issues.apache.org/jira/browse/OOZIE-651


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
  trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 

Diff: https://reviews.apache.org/r/3441/diff


Testing
-------

Tested against current test cases
Test cases for CoordUtils added
Ran the coordinator rerun example


Thanks,

Virag

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Virag Kothari <vi...@yahoo-inc.com>.


> On 2012-01-12 03:18:42, Mohamed Battisha wrote:
> > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java, line 65
> > <https://reviews.apache.org/r/3441/diff/1/?file=67422#file67422line65>
> >
> >     I am assuming this is just copy and paste from the rerunXCommand

getCoordActionsFromIds() is copy and paste, getCoordActionsFromDates() has been refactored a bit to use logic from CoordActionsInDateRange class.


> On 2012-01-12 03:18:42, Mohamed Battisha wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java, line 460
> > <https://reviews.apache.org/r/3441/diff/1/?file=67421#file67421line460>
> >
> >     what if a null coordActions is returned. you may end up with NPE

Nope.. ParamChecker.null() has been added in the next function accessing coordActions


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4325
-----------------------------------------------------------


On 2012-01-10 02:05:54, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-10 02:05:54)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Mohamed Battisha <mb...@yahoo.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4325
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
<https://reviews.apache.org/r/3441/#comment9732>

    what if a null coordActions is returned. you may end up with NPE



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9733>

    I am assuming this is just copy and paste from the rerunXCommand


looks straightforward. few comments and questions



- Mohamed


On 2012-01-10 02:05:54, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-10 02:05:54)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Virag Kothari <vi...@yahoo-inc.com>.


> On 2012-01-10 03:23:10, Mohamed Battisha wrote:
> > any reasons for moving the list methods from the CoordRerunXCommand to the CoordUtility 
> > it seems to be very related to the rerun command

These methods are being used by rerun command but very similar list methods also exist for retrieving logs for date and action range. So already there is some repetition of these functions. As they are generic methods for parsing date and action ranges, have moved them to the utility class.


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4290
-----------------------------------------------------------


On 2012-01-10 02:05:54, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-10 02:05:54)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Mohamed Battisha <mb...@yahoo.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4290
-----------------------------------------------------------


any reasons for moving the list methods from the CoordRerunXCommand to the CoordUtility 
it seems to be very related to the rerun command

- Mohamed


On 2012-01-10 02:05:54, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-10 02:05:54)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Mohammad Islam <mi...@yahoo.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4552
-----------------------------------------------------------

Ship it!


+1 committing

- Mohammad


On 2012-01-13 00:21:17, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-13 00:21:17)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Mohamed Battisha <mb...@yahoo.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4348
-----------------------------------------------------------

Ship it!


looks good

- Mohamed


On 2012-01-13 00:21:17, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-13 00:21:17)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Virag Kothari <vi...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/
-----------------------------------------------------------

(Updated 2012-01-13 00:21:17.561232)


Review request for oozie, Mohammad Islam and Angelo K. Huang.


Changes
-------

Updated based on reviewer's feedback


Summary
-------

https://issues.apache.org/jira/browse/OOZIE-651


This addresses bug OOZIE-651.
    https://issues.apache.org/jira/browse/OOZIE-651


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
  trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1229389 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
  trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 

Diff: https://reviews.apache.org/r/3441/diff


Testing
-------

Tested against current test cases
Test cases for CoordUtils added
Ran the coordinator rerun example


Thanks,

Virag

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Virag Kothari <vi...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4342
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9780>

    ok



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9781>

    ok



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9782>

    ok



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9783>

    ok



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9784>

    ok



trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/3441/#comment9785>

    ok


- Virag


On 2012-01-10 02:05:54, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-10 02:05:54)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: OOZIE-651: Coordinator rerun fails due to NPE in some cases

Posted by Mohamed Battisha <mb...@yahoo.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4337
-----------------------------------------------------------


sounds good, minor comments


trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9767>

    it will be better if you check for the validity of the date and throw an exception if it is not valid, instead of catching a generic exception 



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9772>

    check for null before adding to the set



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9773>

    catching specific exception will be better



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9774>

    you may specify what is wrong here .. 
    it should be greater than 2 
    



trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java
<https://reviews.apache.org/r/3441/#comment9775>

    specify what is wrong will be easy to debug



trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/3441/#comment9770>

    catching the specific exception would be better


- Mohamed


On 2012-01-10 02:05:54, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3441/
> -----------------------------------------------------------
> 
> (Updated 2012-01-10 02:05:54)
> 
> 
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> This addresses bug OOZIE-651.
>     https://issues.apache.org/jira/browse/OOZIE-651
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1229389 
>   trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1229389 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java PRE-CREATION 
>   trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
> 
> Diff: https://reviews.apache.org/r/3441/diff
> 
> 
> Testing
> -------
> 
> Tested against current test cases
> Test cases for CoordUtils added
> Ran the coordinator rerun example
> 
> 
> Thanks,
> 
> Virag
> 
>