You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/13 13:11:49 UTC
[GitHub] [hive] moomindani opened a new pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
moomindani opened a new pull request #1402:
URL: https://github.com/apache/hive/pull/1402
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This change makes it possible for users to choose an implementation of IMetaStoreClient via HiveConf, i.e. hive-site.xml.
This patch is to retry merging the patch of HIVE-12679.
I talked with Austin, the original contributor for this issue, and he said it is okay to submit this patch again.
https://issues.apache.org/jira/browse/HIVE-12679
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently, in Hive the choice is hard coded to be SessionHiveMetaStoreClient in org.apache.hadoop.hive.ql.metadata.Hive.
There is no other direct reference to SessionHiveMetaStoreClient other than the hard coded class name in Hive.java and the QL component operates only on the IMetaStoreClient interface so the change would be minimal and it would be quite similar to how an implementation of RawStore is specified and loaded in hive-metastore. One use case this change would serve would be one where a user wishes to use an implementation of this interface without the dependency on the Thrift server.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. User will be able to specify own implementation of IMetaStoreClient. (e.g. IMetaStoreClient for AWS Glue Data Catalog).
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test and integration test with Glue Data Catalog client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh removed a comment on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
sankarh removed a comment on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-678378941
Patch LGTM
Thanks @moomindani!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1402:
URL: https://github.com/apache/hive/pull/1402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh edited a comment on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
sankarh edited a comment on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-678378941
Patch LGTM
Thanks @moomindani!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-717629984
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] moomindani edited a comment on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
moomindani edited a comment on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-682448121
@sankarh Thank you for the comment, I will try to address it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh commented on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
sankarh commented on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-678382353
I would like to bring up the comment from @thejasmn which sounds valid to me.
"Note that SessionHiveMetaStoreClient implements logic for temp tables, as they have a lifetime of a session. I am wondering if this config should determine which IMetaStoreClient impl is used by SessionHiveMetaStoreClient, instead of replacing SessionHiveMetaStoreClient itself.
Some changes to SessionHiveMetaStoreClient would be needed as well for that approach, for it to accept configured IMetaStoreClient."
Would you pls address this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sankarh commented on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
sankarh commented on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-678378941
+1
Patch LGTM
Thanks @moomindani!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] moomindani commented on pull request #1402: HIVE-12679: Allow users to be able to specify an implementation of IMetaStoreClient via HiveConf
Posted by GitBox <gi...@apache.org>.
moomindani commented on pull request #1402:
URL: https://github.com/apache/hive/pull/1402#issuecomment-682448121
sankarh@ Thank you for the comment, I will try to address it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org