You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/04/13 16:21:49 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #4551: Flink - Remove support for Flink 1.12 before next major release
kbendick opened a new pull request, #4551:
URL: https://github.com/apache/iceberg/pull/4551
Remove support for Flink 1.12, which has been deprecated.
Flink 1.12 has been deprecated and is no longer actively maintained upstream, as the Flink community retains support for 2 major versions at a time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #4551: Flink - Remove support for Flink 1.12
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4551:
URL: https://github.com/apache/iceberg/pull/4551#discussion_r849676972
##########
versions.props:
##########
@@ -1,7 +1,7 @@
org.slf4j:* = 1.7.25
org.apache.avro:avro = 1.10.1
org.apache.calcite:* = 1.10.0
-org.apache.flink:* = 1.12.5
+org.apache.flink:* = 1.14.3
Review Comment:
I don't think this is being used at all given we've moved to versioned Flink dependencies, but I updated it to the latest released Flink version.
Realistically we should potentially get rid of it, as well as others that aren't used now.
The calcite dependency is also somewhat suspect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #4551: Flink - Remove support for Flink 1.12
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4551:
URL: https://github.com/apache/iceberg/pull/4551#discussion_r850045496
##########
versions.props:
##########
@@ -1,7 +1,7 @@
org.slf4j:* = 1.7.25
org.apache.avro:avro = 1.10.1
org.apache.calcite:* = 1.10.0
-org.apache.flink:* = 1.12.5
+org.apache.flink:* = 1.14.3
Review Comment:
There are a few that I think can be removed (eg the Spark dependencies).
One that I’m less sure about is Calcite
I can remove the Flink property in this PR or attempt to clean up several in a secondary PR (or both).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #4551: Flink - Remove support for Flink 1.12 before next major release
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #4551:
URL: https://github.com/apache/iceberg/pull/4551#discussion_r849676972
##########
versions.props:
##########
@@ -1,7 +1,7 @@
org.slf4j:* = 1.7.25
org.apache.avro:avro = 1.10.1
org.apache.calcite:* = 1.10.0
-org.apache.flink:* = 1.12.5
+org.apache.flink:* = 1.14.3
Review Comment:
I don't think this is being used at all, but I updated it to the latest released Flink version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx merged pull request #4551: Flink - Remove support for Flink 1.12
Posted by GitBox <gi...@apache.org>.
openinx merged PR #4551:
URL: https://github.com/apache/iceberg/pull/4551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #4551: Flink - Remove support for Flink 1.12
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #4551:
URL: https://github.com/apache/iceberg/pull/4551#discussion_r849797293
##########
versions.props:
##########
@@ -1,7 +1,7 @@
org.slf4j:* = 1.7.25
org.apache.avro:avro = 1.10.1
org.apache.calcite:* = 1.10.0
-org.apache.flink:* = 1.12.5
+org.apache.flink:* = 1.14.3
Review Comment:
yeah. it does seem that we can remove this property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on a diff in pull request #4551: Flink - Remove support for Flink 1.12
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #4551:
URL: https://github.com/apache/iceberg/pull/4551#discussion_r850206433
##########
versions.props:
##########
@@ -1,7 +1,7 @@
org.slf4j:* = 1.7.25
org.apache.avro:avro = 1.10.1
org.apache.calcite:* = 1.10.0
-org.apache.flink:* = 1.12.5
+org.apache.flink:* = 1.14.3
Review Comment:
I'm okay to remove this in the future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org