You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Santhosh Raman (JIRA)" <ji...@apache.org> on 2012/06/21 07:10:43 UTC
[jira] [Created] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Santhosh Raman created HIVE-3169:
------------------------------------
Summary: Add a way to differentiate between hooks that should/should not fail a query
Key: HIVE-3169
URL: https://issues.apache.org/jira/browse/HIVE-3169
Project: Hive
Issue Type: Bug
Components: Query Processor
Reporter: Santhosh Raman
Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Santhosh Raman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Raman reassigned HIVE-3169:
------------------------------------
Assignee: Santhosh Raman
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
> Assignee: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416052#comment-13416052 ]
Namit Jain commented on HIVE-3169:
----------------------------------
@Santhosh, is it ready for review ?
Please 'Submit Patch' in that case
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
> Assignee: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398274#comment-13398274 ]
Carl Steinbach commented on HIVE-3169:
--------------------------------------
@Santosh: Please see my comments on phabricator. Thanks.
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412574#comment-13412574 ]
Namit Jain commented on HIVE-3169:
----------------------------------
@Santosh, are you still working on this ?
Otherwise, I can take it over.
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
> Assignee: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Santhosh Raman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398204#comment-13398204 ]
Santhosh Raman commented on HIVE-3169:
--------------------------------------
I have a diff ready for this - https://reviews.facebook.net/D3741
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Santhosh Raman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415980#comment-13415980 ]
Santhosh Raman commented on HIVE-3169:
--------------------------------------
Since the old diff and new diff are pretty different, I have created a new diff for this:
https://reviews.facebook.net/D4167
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
> Assignee: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3169) Add a way to differentiate between
hooks that should/should not fail a query
Posted by "Santhosh Raman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Raman updated HIVE-3169:
---------------------------------
Status: Patch Available (was: Open)
The new diff can be found here:
https://reviews.facebook.net/D4167
> Add a way to differentiate between hooks that should/should not fail a query
> ----------------------------------------------------------------------------
>
> Key: HIVE-3169
> URL: https://issues.apache.org/jira/browse/HIVE-3169
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Santhosh Raman
> Assignee: Santhosh Raman
>
> Right now, if any hook fails the query fails. In particular if a post hook fails, even if the query itself succeeded, it will fail because of this.
> In some cases, this may be desired behavior, e.g. if the Replication Hook fails the output will not be replicated (there are arguments for and against this but that is probably best left for a separated discussion).
> However, if something like the sample concurrency hook fails, we could just leave concurrency untouched, display a warning to the user (to hopefully either provoke a Hive Users post from the user or at least have it show up in the log monitor), and continue the query.
> We need to add a way to differentiate between these hooks and to add that error handling.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira