[GitHub] [flink] XComp commented on a diff in pull request #19275: [FLINK-24491][runtime] Make the job termination wait until the archiving of ExecutionGraphInfo finishes

[GitBox <gi...@apache.org>]

XComp commented on code in PR #19275:
URL: https://github.com/apache/flink/pull/19275#discussion_r841538152


##########
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java:
##########
@@ -186,6 +193,9 @@ private void startDispatcher(
                                 // because cleaning it will trigger the closeAsync latch
                                 // provided by TestingJobManagerRunner
                                 .withLocallyCleanableResource(jobManagerRunnerRegistry)
+                                .withGloballyCleanableResource(
+                                        DispatcherResourceCleanerFactory.ofLocalResource(
+                                                jobManagerRunnerRegistry))

Review Comment:
   Why do we need to add this here? The `JobManagerRegistry` needs to be added explicitly because of `testJobSubmissionUnderSameJobId` where we're waiting for the JobManagerRunner to close first. But I don't see a need to add it as a global cleanup because we're not doing something similar for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org