You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/23 10:20:59 UTC
[GitHub] [incubator-shardingsphere] ranjeet-floyd opened a new pull request #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
ranjeet-floyd opened a new pull request #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
URL: https://github.com/apache/incubator-shardingsphere/pull/4900
Fixes #4786.
Changes proposed in this pull request:
- Load ShardingMetaDataLoader metadata for different data sources concurrently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
URL: https://github.com/apache/incubator-shardingsphere/pull/4900#issuecomment-602538042
## Pull Request Test Coverage Report for [Build 10500](https://coveralls.io/builds/29548339)
* **0** of **16** **(0.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.04%**) to **58.069%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29548339/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L59) | 0 | 16 | 0.0%
<!-- | **Total:** | **0** | **16** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/29548339) |
| :-- | --: |
| Change from base [Build 10493](https://coveralls.io/builds/29542363): | -0.04% |
| Covered Lines: | 11885 |
| Relevant Lines: | 20467 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] ranjeet-floyd commented on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
Posted by GitBox <gi...@apache.org>.
ranjeet-floyd commented on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
URL: https://github.com/apache/incubator-shardingsphere/pull/4900#issuecomment-602530537
@terrymanu Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
URL: https://github.com/apache/incubator-shardingsphere/pull/4900#issuecomment-602535863
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=h1) Report
> Merging [#4900](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ac11781e16d31a7da719d58d5ec491b19a0afadf&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4900 +/- ##
============================================
- Coverage 54.59% 54.55% -0.05%
Complexity 434 434
============================================
Files 1138 1138
Lines 20452 20467 +15
Branches 3762 3762
============================================
Hits 11166 11166
- Misses 8579 8594 +15
Partials 707 707
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=footer). Last update [ac11781...ed3658f](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
URL: https://github.com/apache/incubator-shardingsphere/pull/4900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4900: Load ShardingMetaDataLoader metadata for different data sources concu…
URL: https://github.com/apache/incubator-shardingsphere/pull/4900#issuecomment-602538042
## Pull Request Test Coverage Report for [Build 10499](https://coveralls.io/builds/29547967)
* **0** of **16** **(0.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.04%**) to **58.069%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29547967/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L59) | 0 | 16 | 0.0%
<!-- | **Total:** | **0** | **16** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/29547967) |
| :-- | --: |
| Change from base [Build 10493](https://coveralls.io/builds/29542363): | -0.04% |
| Covered Lines: | 11885 |
| Relevant Lines: | 20467 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services