[jira] Commented: (SHINDIG-500) Make Gadget Object's content that of the active View

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622037#action_12622037 ] 

Kevin Brown commented on SHINDIG-500:
-------------------------------------

No, it isn't acceptable.. As Louis and I have posted on other bugs, rewriting (and associated sub-processes) is one of the most expensive operations done by Shindig today (after RSA signing and content encoding detection). We need to optimize this in the long run anyway, but we can't afford to rewrite every render in the short term either.

The rewritten content must be cached as much as possible. You can cache the content separately from the spec, but it must be cached somewhere.

Re: SpecFactory

GadgetSpecs should be immutable. The mutable bits that have been added are a design mistake made over the last several months as feature creep has risen. There's no need for more nuanced behavior for basic retrieval, and if there was, it would just be another GadgetSpecFactory implementation, not more logic wedged into GadgetServer (which is already doing more work than it should be).

Really, GadgetServer needs to be scrapped entirely, and there should be separate classes for dealing with the two main gadget operations:

1. A code path that deals with rendering gadgets
2. A code path that deals with extracting metadata from gadgets

Both of these exist in skeleton form at the servlet level, where gadget rendering is clearly separated from metadata access, but under the covers they both use GadgetServer, which is just terrible to work with.

> Make Gadget Object's content that of the active View
> ----------------------------------------------------
>
>                 Key: SHINDIG-500
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-500
>             Project: Shindig
>          Issue Type: Sub-task
>          Components: Gadget Rendering Server (Java)
>            Reporter: John Hjelmstad
>            Assignee: John Hjelmstad
>         Attachments: shindig-500.diff
>
>
> Step #1 of http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200808.mbox/%3cab5e78ed0808061534r48c04de5j8909bc7e8316cc22@mail.gmail.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.