You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/24 03:43:01 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #10394: [Bug][docs] Fix wrong links in README.md
adonis0147 opened a new pull request, #10394:
URL: https://github.com/apache/doris/pull/10394
# Proposed changes
Issue Number: close #10393
## Problem Summary:
Please refer to #10393
## Checklist(Required)
1. Does it affect the original behavior: No
2. Has unit tests been added: No Need
3. Has document been added or modified: No Need
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10394:
URL: https://github.com/apache/doris/pull/10394#issuecomment-1169477403
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10394:
URL: https://github.com/apache/doris/pull/10394#issuecomment-1169477391
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10394:
URL: https://github.com/apache/doris/pull/10394#issuecomment-1173414588
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #10394:
URL: https://github.com/apache/doris/pull/10394#discussion_r905763752
##########
README.md:
##########
@@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/
## Compile and install
-See [Compilation](https://doris.apache.org/install/source-install/compilation-with-ldb-toolchain.html)
+See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html)
Review Comment:
Hi @Hisoka-X , I think it is better to recommend novices compile the codebase by [ldb toolchain](https://github.com/amosbird/ldb_toolchain_gen) for the following reasons:
1. It is difficult for users without root privilege to deploy `docker` on server.
2. It is easy to install [ldb toolchain](https://github.com/amosbird/ldb_toolchain_gen) and it is validated even on Centos 6.
3. [Dockerfile](https://github.com/apache/doris/blob/master/docker/Dockerfile) provided by Doris also uses [ldb toolchain](https://github.com/apache/doris/blob/9036f93df4a54e218c0ccb3ff2496bce39f5099d/docker/Dockerfile#L45) to build the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #10394:
URL: https://github.com/apache/doris/pull/10394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Hisoka-X commented on a diff in pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #10394:
URL: https://github.com/apache/doris/pull/10394#discussion_r905741442
##########
README.md:
##########
@@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/
## Compile and install
-See [Compilation](https://doris.apache.org/install/source-install/compilation-with-ldb-toolchain.html)
+See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html)
Review Comment:
```suggestion
See [Compilation](https://doris.apache.org/docs/install/source-install/compilation.html)
```
##########
README.md:
##########
@@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/
## Compile and install
-See [Compilation](https://doris.apache.org/install/source-install/compilation-with-ldb-toolchain.html)
+See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html)
Review Comment:
Maybe use compilation.html as link better, because this is compile's first sub page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Hisoka-X commented on a diff in pull request #10394: [Bug][docs] Fix wrong links in README.md
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #10394:
URL: https://github.com/apache/doris/pull/10394#discussion_r905771918
##########
README.md:
##########
@@ -55,11 +55,11 @@ Doris mainly integrates the technology of [Google Mesa](https://research.google/
## Compile and install
-See [Compilation](https://doris.apache.org/install/source-install/compilation-with-ldb-toolchain.html)
+See [Compilation](https://doris.apache.org/docs/install/source-install/compilation-with-ldb-toolchain.html)
Review Comment:
I got it. Thanks for reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org