You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by llhe <gi...@git.apache.org> on 2014/12/10 16:05:58 UTC
[GitHub] thrift pull request: Fix THRIFT-2779 - PHP TJSONProtocol encode un...
GitHub user llhe opened a pull request:
https://github.com/apache/thrift/pull/313
Fix THRIFT-2779 - PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other langurage bindings
Fix THRIFT-2779
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/llhe/thrift t2779
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit 2c6e7d06161775d7dea2ba6c791692ec66a2aa5f
Author: Liangliang He <ll...@gmail.com>
Date: 2014-12-10T15:01:24Z
Fix THRIFT-2779 - PHP TJSONProtocol encode unicode into UCS-4LE which can't be parsed by other langurage bindings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix THRIFT-2779 - PHP TJSONProtocol encode un...
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/313#issuecomment-66888731
lib/php/test/Test/Thrift/Protocol/TestTJSONProtocol.php:103
this breaks the test suite *make check* and what about *make cross*
2) test\Thrift\Protocol\TestTJSONProtocol::testStringMap_Write
Failed asserting that two strings are equal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Fix THRIFT-2779 - PHP TJSONProtocol encode un...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---