You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/20 10:52:02 UTC
[GitHub] [spark] wangyum commented on a change in pull request #31901: [SPARK-34802][SQL] Move simplify expression rules before operator push down
wangyum commented on a change in pull request #31901:
URL: https://github.com/apache/spark/pull/31901#discussion_r598096072
##########
File path: sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q14a.sf100/explain.txt
##########
@@ -713,13 +713,13 @@ Input [6]: [i_brand_id#8, i_class_id#9, i_category_id#10, sales#80, number_sales
Condition : (isnotnull(sum(CheckOverflow((promote_precision(cast(cast(ws_quantity#68 as decimal(10,0)) as decimal(12,2))) * promote_precision(cast(ws_list_price#69 as decimal(12,2)))), DecimalType(18,2), true))#82) AND (cast(sum(CheckOverflow((promote_precision(cast(cast(ws_quantity#68 as decimal(10,0)) as decimal(12,2))) * promote_precision(cast(ws_list_price#69 as decimal(12,2)))), DecimalType(18,2), true))#82 as decimal(32,6)) > cast(ReusedSubquery Subquery scalar-subquery#49, [id=#50] as decimal(32,6))))
(128) Project [codegen id : 135]
-Output [6]: [sales#80, number_sales#81, web AS channel#83, i_brand_id#8, i_class_id#9, i_category_id#10]
+Output [10]: [web AS channel#83, i_brand_id#8, i_class_id#9, i_category_id#10, sales#80, number_sales#81, web AS channel#83, i_brand_id#8, i_class_id#9, i_category_id#10]
Input [6]: [i_brand_id#8, i_class_id#9, i_category_id#10, sales#80, number_sales#81, sum(CheckOverflow((promote_precision(cast(cast(ws_quantity#68 as decimal(10,0)) as decimal(12,2))) * promote_precision(cast(ws_list_price#69 as decimal(12,2)))), DecimalType(18,2), true))#82]
(129) Union
(130) Expand [codegen id : 136]
-Input [6]: [sales#46, number_sales#47, channel#51, i_brand_id#8, i_class_id#9, i_category_id#10]
+Input [10]: [channel#51, i_brand_id#8, i_class_id#9, i_category_id#10, sales#46, number_sales#47, channel#51, i_brand_id#8, i_class_id#9, i_category_id#10]
Review comment:
Yes. Only move simplify expression rules before `// Operator push down`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org