You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "danielhumanmod (via GitHub)" <gi...@apache.org> on 2025/11/21 07:17:39 UTC
[PR] chore: update datafusion to 51.0 [datafusion-ballista]
danielhumanmod opened a new pull request, #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "danielhumanmod (via GitHub)" <gi...@apache.org>.
danielhumanmod commented on PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345#issuecomment-3567578813
Hey @milenkovicm — I continued your work by adding the new metrics type support, adjusting DF API usages, and updating the related tests. CI looks fine, appreciate your feedback whenever you get a chance. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm merged PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345#issuecomment-3569732035
Thanks @danielhumanmod will have a look later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345#issuecomment-3588605518
thanks @danielhumanmod it looks good!
I've pushed commit, removed unnecessary context creation from few more places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "danielhumanmod (via GitHub)" <gi...@apache.org>.
danielhumanmod commented on PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345#issuecomment-3588082274
> I think pr makes sense, thanks a lot! just few minor comments. Also, could you please update datafusion and datafusion-common.proto files to reflect df 51 versions (we usually do it with every df update)
Thanks for the feedback! Updated all the comments in latest commit, feel free to merge it or let me know any further improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "danielhumanmod (via GitHub)" <gi...@apache.org>.
danielhumanmod commented on code in PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345#discussion_r2553813039
##########
Cargo.toml:
##########
@@ -27,27 +27,28 @@ resolver = "2"
#
edition = "2021"
# we should try to follow datafusion version
-rust-version = "1.86.0"
+rust-version = "1.88.0"
Review Comment:
Try to align with DataFusion rust version, feel free to let me know if we dont want to bump it right now
https://github.com/apache/datafusion/blob/main/Cargo.toml#L80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: update datafusion to 51.0 [datafusion-ballista]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on code in PR #1345:
URL: https://github.com/apache/datafusion-ballista/pull/1345#discussion_r2557178713
##########
ballista/executor/src/execution_loop.rs:
##########
@@ -251,8 +250,7 @@ async fn run_received_task<T: 'static + AsLogicalPlan, U: 'static + AsExecutionP
.with_config(session_config.clone())
.with_runtime_env(runtime.clone())
.build();
- let ctx = SessionContext::new_with_state(session_state);
- //
+ let ctx = SessionContext::new_with_state(session_state).task_ctx();
Review Comment:
can we create TaskContext directly? we should have all required info for TaskContext
##########
Cargo.toml:
##########
@@ -27,27 +27,28 @@ resolver = "2"
#
edition = "2021"
# we should try to follow datafusion version
-rust-version = "1.86.0"
+rust-version = "1.88.0"
Review Comment:
I think it makes sense
##########
ballista/core/src/serde/mod.rs:
##########
@@ -286,37 +286,33 @@ impl PhysicalExtensionCodec for BallistaPhysicalExtensionCodec {
// more details at https://github.com/apache/datafusion/issues/17596
let mut state = SessionStateBuilder::new_with_default_features().build();
- for function_name in registry.udfs() {
- if let Ok(function) = registry.udf(&function_name) {
+ for function_name in ctx.udfs() {
+ if let Ok(function) = ctx.udf(&function_name) {
state.register_udf(function)?;
}
}
- for function_name in registry.udafs() {
- if let Ok(function) = registry.udaf(&function_name) {
+ for function_name in ctx.udafs() {
+ if let Ok(function) = ctx.udaf(&function_name) {
state.register_udaf(function)?;
}
}
- for function_name in registry.udafs() {
- if let Ok(function) = registry.udaf(&function_name) {
+ for function_name in ctx.udafs() {
+ if let Ok(function) = ctx.udaf(&function_name) {
state.register_udaf(function)?;
}
}
- let ctx = SessionContext::new_with_state(state);
-
- //
- //
- //
+ let ctx = SessionContext::new_with_state(state).task_ctx();
Review Comment:
same comment, can we create task context directly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org