You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2023/01/10 15:27:48 UTC
[GitHub] [cordova-plugin-file] pjoriginal opened a new pull request, #549: feat(electron): add platform support
pjoriginal opened a new pull request, #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Electron
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
This is required so that cordova electron can have a working file plugin
<!-- If it fixes an open issue, please link to the issue here. -->
fixes #334
fixes #312
fixes #477
closes #371
closes #387
### Description
<!-- Describe your changes in detail -->
~~The base implementation has two things.~~
~~1. Scripts to add and remove node implementations done in files `cdv-electron-main.js` and `cdv-electron-preload.js`. Since the scripts look for comments, and remove code between the comments on plugin remove, we should be good as long as the dev doesn't mess those up. These scripts are added to support [Context Isloation](https://www.electronjs.org/docs/latest/tutorial/context-isolation/) that has been encouraged in electron@^3.0. The `fs` required can be called from `window.cordovaFilePlugin.function`. I had to tweak some changes because the return value objects have their methods removed.~~
With the help of Erisu, I was able to update the code so that it doesn't require extra scripts. The electron implementation uses the `framework` keyword and uses backend node-js functions to implement stuff.
### Testing
<!-- Please describe in detail how you tested your changes. -->
I've tested them on my personal projects. Will write an exclusive test project if necessary,
Also, https://github.com/pjoriginal/cordova-file-test
### Checklist
- [X] I've run the tests to see all new and existing tests pass
- [X] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(electron): add platform support [cordova-plugin-file]
Posted by "Pankaja890 (via GitHub)" <gi...@apache.org>.
Pankaja890 commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-3248646467
@breautek Can this be reviewed and merged. Helps lot of devs building for electron platform. We are currently using a fork of this plugin and it conflicts with other plugins which have this plugin listed as a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] pjoriginal commented on pull request #549: feat(electron): add platform support
Posted by GitBox <gi...@apache.org>.
pjoriginal commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-1377443392
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] breautek commented on pull request #549: feat(electron): add platform support
Posted by GitBox <gi...@apache.org>.
breautek commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-1371559852
The Android & iOS tests can be ignored because there are existing issues present that is causing them to fail, and that's been happening to some time. We know it's not caused by this PR.
Lint test should pass, which it currently does.
> Will write an exclusive test project if necessary
Obviously it will be nice to have actual unit tests, but I won't personally reject a PR without unit tests. It can always be added later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(electron): add platform support [cordova-plugin-file]
Posted by "srinidhirao (via GitHub)" <gi...@apache.org>.
srinidhirao commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-2897349446
@breautek can you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(electron): add platform support [cordova-plugin-file]
Posted by "pjoriginal (via GitHub)" <gi...@apache.org>.
pjoriginal commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-1956055554
Making chnages to make this compatible to `electron@nightly`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] pjoriginal closed pull request #549: feat(electron): add platform support
Posted by GitBox <gi...@apache.org>.
pjoriginal closed pull request #549: feat(electron): add platform support
URL: https://github.com/apache/cordova-plugin-file/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] regnete commented on pull request #549: feat(electron): add platform support
Posted by "regnete (via GitHub)" <gi...@apache.org>.
regnete commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-1689771050
When will this be committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] pjoriginal commented on pull request #549: feat(electron): add platform support
Posted by GitBox <gi...@apache.org>.
pjoriginal commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-1377445420
I'm sorry.
I accidentally clicked on "close this issue" while trying to comment on the issue.
The test project has been created. Will add unit tests soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-file] pjoriginal commented on pull request #549: feat(electron): add platform support
Posted by "pjoriginal (via GitHub)" <gi...@apache.org>.
pjoriginal commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-1521281151
@breautek added functionality and added electron stuff to tests where missing. Also fixed eslint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(electron): add platform support [cordova-plugin-file]
Posted by "srinidhirao (via GitHub)" <gi...@apache.org>.
srinidhirao commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-2893753919
@pjoriginal can you please get the conflicts resolved and push for a merge? Great work on adding the electron platform, we are using it one of the apps. The challenge that we have is keeping the other platform code updated with the main. So, if this gets merged, then it would avoid us a hassle of maintaining another fork of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] feat(electron): add platform support [cordova-plugin-file]
Posted by "pjoriginal (via GitHub)" <gi...@apache.org>.
pjoriginal commented on PR #549:
URL: https://github.com/apache/cordova-plugin-file/pull/549#issuecomment-2895252219
@srinidhirao I will do that within 24 hours and push it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org