You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sollhui (via GitHub)" <gi...@apache.org> on 2024/09/10 08:39:48 UTC

[PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

sollhui opened a new pull request, #40613:
URL: https://github.com/apache/doris/pull/40613

   fix allocate size improper in append_and_flush introduced by https://github.com/apache/doris/pull/38960
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2340058342

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 merged PR #40613:
URL: https://github.com/apache/doris/pull/40613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2340058457

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2340032194

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2340032044

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2340046776

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2340089362

   TeamCity be ut coverage result:
    Function Coverage: 36.84% (9397/25508) 
    Line Coverage: 28.23% (77509/274521)
    Region Coverage: 27.64% (40018/144801)
    Branch Coverage: 24.26% (20354/83894)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/84d68885d52e3874a2c11f01ab9d037d408451a9_84d68885d52e3874a2c11f01ab9d037d408451a9/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2342897640

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.48 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 84d68885d52e3874a2c11f01ab9d037d408451a9, data reload: false
   
   query1	0.05	0.04	0.03
   query2	0.08	0.04	0.04
   query3	0.22	0.04	0.05
   query4	1.67	0.06	0.07
   query5	0.51	0.52	0.52
   query6	1.13	0.74	0.74
   query7	0.01	0.01	0.02
   query8	0.05	0.04	0.05
   query9	0.54	0.48	0.49
   query10	0.53	0.55	0.56
   query11	0.15	0.12	0.12
   query12	0.15	0.12	0.12
   query13	0.60	0.58	0.59
   query14	1.43	1.42	1.41
   query15	0.84	0.81	0.84
   query16	0.37	0.37	0.37
   query17	0.99	1.01	1.02
   query18	0.21	0.20	0.20
   query19	1.79	1.79	1.78
   query20	0.01	0.01	0.01
   query21	15.39	0.66	0.66
   query22	4.28	5.62	3.01
   query23	18.34	1.39	1.26
   query24	2.12	0.22	0.22
   query25	0.16	0.08	0.08
   query26	0.26	0.18	0.18
   query27	0.08	0.07	0.08
   query28	13.25	1.01	1.00
   query29	12.68	3.32	3.36
   query30	0.26	0.06	0.05
   query31	2.86	0.39	0.39
   query32	3.26	0.48	0.47
   query33	2.98	3.02	3.08
   query34	17.20	4.37	4.37
   query35	4.40	4.49	4.40
   query36	0.66	0.47	0.47
   query37	0.18	0.16	0.15
   query38	0.16	0.14	0.15
   query39	0.05	0.04	0.05
   query40	0.15	0.12	0.12
   query41	0.09	0.05	0.06
   query42	0.06	0.05	0.05
   query43	0.05	0.04	0.04
   Total cold run time: 110.25 s
   Total hot run time: 32.48 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2342886733

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 197772 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 84d68885d52e3874a2c11f01ab9d037d408451a9, data reload: false
   
   query1	1272	890	874	874
   query2	6369	1968	1938	1938
   query3	10650	4053	3958	3958
   query4	59753	26000	23529	23529
   query5	5019	516	520	516
   query6	391	163	156	156
   query7	5617	288	286	286
   query8	335	225	226	225
   query9	7937	2503	2497	2497
   query10	440	278	268	268
   query11	17300	15143	15335	15143
   query12	154	105	106	105
   query13	1469	412	422	412
   query14	10600	7399	8042	7399
   query15	207	182	175	175
   query16	6812	452	432	432
   query17	1148	627	562	562
   query18	1550	286	299	286
   query19	203	153	147	147
   query20	125	109	108	108
   query21	202	103	103	103
   query22	4961	4475	4707	4475
   query23	34376	33505	33543	33505
   query24	5951	2828	2841	2828
   query25	492	377	379	377
   query26	612	148	145	145
   query27	1625	272	279	272
   query28	3691	2054	2030	2030
   query29	643	407	401	401
   query30	234	158	157	157
   query31	911	770	788	770
   query32	73	55	53	53
   query33	403	300	286	286
   query34	889	472	470	470
   query35	878	709	725	709
   query36	1042	930	930	930
   query37	142	84	83	83
   query38	4177	3881	3955	3881
   query39	1442	1411	1431	1411
   query40	191	115	113	113
   query41	47	44	44	44
   query42	113	94	93	93
   query43	519	496	458	458
   query44	1091	748	750	748
   query45	197	164	162	162
   query46	1089	737	742	737
   query47	1908	1785	1827	1785
   query48	359	287	290	287
   query49	793	440	462	440
   query50	815	417	417	417
   query51	7073	6958	6893	6893
   query52	100	88	84	84
   query53	244	180	178	178
   query54	555	455	452	452
   query55	74	76	76	76
   query56	279	259	259	259
   query57	1200	1080	1080	1080
   query58	214	229	228	228
   query59	3000	3006	2722	2722
   query60	289	260	265	260
   query61	100	99	98	98
   query62	739	657	664	657
   query63	218	184	186	184
   query64	1410	681	665	665
   query65	3250	3171	3134	3134
   query66	614	332	342	332
   query67	15876	15787	15415	15415
   query68	1191	550	551	550
   query69	385	269	264	264
   query70	1193	1161	1107	1107
   query71	321	272	277	272
   query72	4686	4046	4210	4046
   query73	736	318	320	318
   query74	9137	8930	8892	8892
   query75	3343	2750	2766	2750
   query76	1320	997	1050	997
   query77	429	322	327	322
   query78	9784	9378	9271	9271
   query79	933	866	863	863
   query80	825	786	778	778
   query81	460	259	260	259
   query82	266	264	259	259
   query83	193	189	191	189
   query84	260	104	104	104
   query85	703	402	377	377
   query86	307	301	317	301
   query87	4404	4452	4344	4344
   query88	4666	3994	4003	3994
   query89	373	359	370	359
   query90	2298	310	303	303
   query91	185	116	118	116
   query92	78	73	74	73
   query93	905	905	901	901
   query94	767	373	359	359
   query95	452	402	403	402
   query96	463	460	461	460
   query97	3148	3137	3110	3110
   query98	221	239	222	222
   query99	1452	1316	1307	1307
   Total cold run time: 298336 ms
   Total hot run time: 197772 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](bytebuffer) fix allocate size improper in append_and_flush [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40613:
URL: https://github.com/apache/doris/pull/40613#issuecomment-2342863735

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38433 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 84d68885d52e3874a2c11f01ab9d037d408451a9, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17603	4727	4353	4353
   q2	2008	185	183	183
   q3	11627	935	1163	935
   q4	10522	783	776	776
   q5	7787	2879	2863	2863
   q6	231	141	141	141
   q7	969	615	627	615
   q8	9322	2073	2069	2069
   q9	7090	6570	6613	6570
   q10	7017	2263	2252	2252
   q11	471	239	246	239
   q12	402	227	230	227
   q13	17759	3070	3081	3070
   q14	281	239	250	239
   q15	549	485	504	485
   q16	529	442	437	437
   q17	972	692	767	692
   q18	7537	6985	6915	6915
   q19	1381	1100	1055	1055
   q20	687	340	340	340
   q21	3963	3088	2974	2974
   q22	1122	1003	1021	1003
   Total cold run time: 109829 ms
   Total hot run time: 38433 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4323	4302	4308	4302
   q2	394	270	276	270
   q3	2892	2627	2632	2627
   q4	1939	1616	1681	1616
   q5	5717	5693	5816	5693
   q6	236	141	137	137
   q7	2250	1895	1855	1855
   q8	3315	3449	3551	3449
   q9	8955	8904	8889	8889
   q10	3623	3413	3368	3368
   q11	618	522	500	500
   q12	826	686	653	653
   q13	13749	3157	3287	3157
   q14	318	291	291	291
   q15	548	483	499	483
   q16	553	501	502	501
   q17	1864	1562	1561	1561
   q18	8203	7886	8009	7886
   q19	1807	1502	1551	1502
   q20	2201	1913	1904	1904
   q21	5714	5660	5510	5510
   q22	1120	1030	1034	1030
   Total cold run time: 71165 ms
   Total hot run time: 57184 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org