You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2023/12/18 14:20:14 UTC
[PR] feat: update realease shell scripts [dubbo-kubernetes]
yuluo-yx opened a new pull request, #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116
## What is the purpose of the change
- For https://github.com/apache/dubbo-kubernetes/issues/114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx commented on code in PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#discussion_r1431469034
##########
release/downloadDubbo.sh:
##########
@@ -25,7 +25,7 @@ fi
# Determine the latest Dubbo version by version number ignoring alpha, beta, and rc versions.
if [ "${DUBBO_VERSION}" = "" ] ; then
- DUBBO_VERSION="$(curl -sL https://github.com/dawnzzz/dubbo-kubernetes/releases | \
+ DUBBO_VERSION="$(curl -sL https://github.com/apache/dubbo/releases | \
Review Comment:
I think I understand it, I will file a pr correction, tks 🫡 @dawnzzz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "dawnzzz (via GitHub)" <gi...@apache.org>.
dawnzzz commented on code in PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#discussion_r1431449071
##########
release/downloadDubbo.sh:
##########
@@ -25,7 +25,7 @@ fi
# Determine the latest Dubbo version by version number ignoring alpha, beta, and rc versions.
if [ "${DUBBO_VERSION}" = "" ] ; then
- DUBBO_VERSION="$(curl -sL https://github.com/dawnzzz/dubbo-kubernetes/releases | \
+ DUBBO_VERSION="$(curl -sL https://github.com/apache/dubbo/releases | \
Review Comment:
Thx reply😄
please check dubbo-release workflow in https://github.com/apache/dubbo-kubernetes/blob/master/.github/workflows/dubbo-release.yaml, we defined a versioned dubbo release consists of dubboctl + dubbo-cp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx commented on code in PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#discussion_r1431431340
##########
release/downloadDubbo.sh:
##########
@@ -25,7 +25,7 @@ fi
# Determine the latest Dubbo version by version number ignoring alpha, beta, and rc versions.
if [ "${DUBBO_VERSION}" = "" ] ; then
- DUBBO_VERSION="$(curl -sL https://github.com/dawnzzz/dubbo-kubernetes/releases | \
+ DUBBO_VERSION="$(curl -sL https://github.com/apache/dubbo/releases | \
Review Comment:
The name of this script is downloadDubbo.sh. This is how downloadDuboctl.sh is configured.
In other words, we only need one script to complete the work of downloading dubbo, dubboctl, and dubbo-cp, instead of two scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx commented on code in PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#discussion_r1431469034
##########
release/downloadDubbo.sh:
##########
@@ -25,7 +25,7 @@ fi
# Determine the latest Dubbo version by version number ignoring alpha, beta, and rc versions.
if [ "${DUBBO_VERSION}" = "" ] ; then
- DUBBO_VERSION="$(curl -sL https://github.com/dawnzzz/dubbo-kubernetes/releases | \
+ DUBBO_VERSION="$(curl -sL https://github.com/apache/dubbo/releases | \
Review Comment:
I think I understand it, I will file a pr correction, tks @dawnzzz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#issuecomment-1861983789
## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/116?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ea38a28`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/ea38a28c803261de6e18746284535909d10b7d6a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.52% compared to head [(`5a1f368`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/116?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.52%.
> :exclamation: Current head 5a1f368 differs from pull request most recent head 5be8a33. Consider uploading reports for the commit 5be8a33 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 48.52% 48.52%
=======================================
Files 148 148
Lines 9568 9568
Branches 41 41
=======================================
Hits 4643 4643
Misses 4397 4397
Partials 528 528
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/116?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat: update realease shell scripts [dubbo-kubernetes]
Posted by "dawnzzz (via GitHub)" <gi...@apache.org>.
dawnzzz commented on code in PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#discussion_r1431393108
##########
release/downloadDubbo.sh:
##########
@@ -25,7 +25,7 @@ fi
# Determine the latest Dubbo version by version number ignoring alpha, beta, and rc versions.
if [ "${DUBBO_VERSION}" = "" ] ; then
- DUBBO_VERSION="$(curl -sL https://github.com/dawnzzz/dubbo-kubernetes/releases | \
+ DUBBO_VERSION="$(curl -sL https://github.com/apache/dubbo/releases | \
Review Comment:
this is a script to download dubbo, which includes dubbo-cp and dubboctl.
so, I think the correct url is https://github.com/apache/dubbo-kubernetes/releases. The following also needs to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org