[jira] [Commented] (NIFI-447) Add "Replacement Strategy" property to ReplaceText

["Mark Payne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947038#comment-14947038 ] 

Mark Payne commented on NIFI-447:
---------------------------------

Hey [~JPercivall] was just looking over this patch. I think the way that the Literal Replacement strategy was implemented is a little bit different than I was expecting. When the user chooses to do a Literal Replacement, there shouldn't be a regular expression entered at all. Instead, the value to search for is a literal string value. This means that the Regular Expression property should probably also be renamed to Search Value, because the search value is not always a regular expression anymore.

> Add "Replacement Strategy" property to ReplaceText
> --------------------------------------------------
>
>                 Key: NIFI-447
>                 URL: https://issues.apache.org/jira/browse/NIFI-447
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Payne
>             Fix For: 0.4.0
>
>         Attachments: NIFI-447.patch
>
>
> "Regular Expression" property should have displayName changed to "Search Value"
> ReplaceText should allow for a "Replacement Strategy" with values:
> Prepend (Search Value is ignored; replacement value prepended to FlowFile)
> Append (Search Value is ignored; replacement value appended to FlowFIle)
> Regex Replace (current behavior, so this should be default)
> Linewise Regex Replace (like current behavior if Evaluation Mode is set to Line-by-Line)
> Literal Replace (do not interpret the Replacement value
> The Line-by-Line property should be removed; this is breaking change!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)