[GitHub] [zookeeper] lvfangmin commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum Packet metrics

[GitBox <gi...@apache.org>]

lvfangmin commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r265852446
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
 ##########
 @@ -82,6 +84,16 @@ long getSid(){
         return sid;
     }
 
+    /**
+     * server identifier used in reporting metrics
+     */
+    private String reportId = null;
 
 Review comment:
   The reportId was added internally to reduce the metric keys because of the large amount of observers we have, we use -1 id for all observers. 
   
   Let's remove it from this PR and use sid directly to make it more straightforward, I don't think this is useful for the community.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services