You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 02:39:31 UTC
[GitHub] [spark] maropu commented on a change in pull request #27252:
[SPARK-29231][SQL] Constraints should be inferred from cast equality
constraint
maropu commented on a change in pull request #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint
URL: https://github.com/apache/spark/pull/27252#discussion_r378012554
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala
##########
@@ -62,11 +62,17 @@ trait ConstraintHelper {
*/
def inferAdditionalConstraints(constraints: Set[Expression]): Set[Expression] = {
var inferredConstraints = Set.empty[Expression]
+ // IsNotNull should be constructed by `constructIsNotNullConstraints`.
+ val predicates = constraints.filterNot(_.isInstanceOf[IsNotNull])
constraints.foreach {
Review comment:
We cannot do it like `predicates.foreach {` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org