You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2018/01/16 03:55:47 UTC
Review Request 65173: HIVE-18386
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-18386
https://issues.apache.org/jira/browse/HIVE-18386
Repository: hive-git
Description
-------
HIVE-18386
Diffs
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 631c83644a2348f16510e9e2b237c8b1107261f6
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java f79dbac5735a245f81e1274c169566fd53208f88
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
Diff: https://reviews.apache.org/r/65173/diff/1/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 65173: HIVE-18386
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On Jan. 17, 2018, 11:10 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
> > Line 157 (original), 183 (patched)
> > <https://reviews.apache.org/r/65173/diff/3/?file=1941302#file1941302line185>
> >
> > Callers of this has conf as well.
In this case, we could use it indeed. However, should we use the conf for the Session when we create the MV or a fresh conf associated with HS2?
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/#review195657
-----------------------------------------------------------
On Jan. 17, 2018, 10:52 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65173/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 10:52 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Bugs: HIVE-18386
> https://issues.apache.org/jira/browse/HIVE-18386
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18386
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b
> data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
> ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
>
>
> Diff: https://reviews.apache.org/r/65173/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 65173: HIVE-18386
Posted by Ashutosh Chauhan <ha...@apache.org>.
> On Jan. 17, 2018, 11:10 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
> > Line 157 (original), 183 (patched)
> > <https://reviews.apache.org/r/65173/diff/3/?file=1941302#file1941302line185>
> >
> > Callers of this has conf as well.
>
> Jesús Camacho Rodríguez wrote:
> In this case, we could use it indeed. However, should we use the conf for the Session when we create the MV or a fresh conf associated with HS2?
conf for session should be ok here.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/#review195657
-----------------------------------------------------------
On Jan. 17, 2018, 10:52 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65173/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 10:52 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Bugs: HIVE-18386
> https://issues.apache.org/jira/browse/HIVE-18386
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18386
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b
> data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
> ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
>
>
> Diff: https://reviews.apache.org/r/65173/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 65173: HIVE-18386
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/#review195657
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
Line 157 (original), 183 (patched)
<https://reviews.apache.org/r/65173/#comment274921>
Callers of this has conf as well.
- Ashutosh Chauhan
On Jan. 17, 2018, 10:52 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65173/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 10:52 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Bugs: HIVE-18386
> https://issues.apache.org/jira/browse/HIVE-18386
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18386
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b
> data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
> ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
>
>
> Diff: https://reviews.apache.org/r/65173/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 65173: HIVE-18386
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/
-----------------------------------------------------------
(Updated Jan. 18, 2018, 12:23 a.m.)
Review request for hive, Ashutosh Chauhan and Thejas Nair.
Bugs: HIVE-18386
https://issues.apache.org/jira/browse/HIVE-18386
Repository: hive-git
Description
-------
HIVE-18386
Diffs (updated)
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b
data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java a917c0794f7165059631a1507355fd793c55b461
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1a2b3c1f6cc9ad6d33449fac001bc8793532e0e0
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
Diff: https://reviews.apache.org/r/65173/diff/5/
Changes: https://reviews.apache.org/r/65173/diff/4-5/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 65173: HIVE-18386
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 10:52 p.m.)
Review request for hive, Ashutosh Chauhan and Thejas Nair.
Bugs: HIVE-18386
https://issues.apache.org/jira/browse/HIVE-18386
Repository: hive-git
Description
-------
HIVE-18386
Diffs (updated)
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b
data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
Diff: https://reviews.apache.org/r/65173/diff/4/
Changes: https://reviews.apache.org/r/65173/diff/3-4/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 65173: HIVE-18386
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 10:34 p.m.)
Review request for hive, Ashutosh Chauhan and Thejas Nair.
Bugs: HIVE-18386
https://issues.apache.org/jira/browse/HIVE-18386
Repository: hive-git
Description
-------
HIVE-18386
Diffs (updated)
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b
data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
Diff: https://reviews.apache.org/r/65173/diff/3/
Changes: https://reviews.apache.org/r/65173/diff/2-3/
Testing
-------
Thanks,
Jesús Camacho Rodríguez
Re: Review Request 65173: HIVE-18386
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
> On Jan. 17, 2018, 12:33 a.m., Ashutosh Chauhan wrote:
> > service/src/java/org/apache/hive/service/server/HiveServer2.java
> > Line 192 (original), 192 (patched)
> > <https://reviews.apache.org/r/65173/diff/2/?file=1940722#file1940722line192>
> >
> > SessionHive should be well formed object here which can be passed in to callee. I see previous method is also using it. Any reason to not do that.
The problem was that the sessionHive might be null because no session had been created. This was causing issues e.g. with authorization. Since creation of HiveConf object is expensive, I have minimized its usage (only once before adding all MVs to cache, and when we actually create a materialized view).
- Jesús
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/#review195524
-----------------------------------------------------------
On Jan. 16, 2018, 10:54 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65173/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 10:54 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Bugs: HIVE-18386
> https://issues.apache.org/jira/browse/HIVE-18386
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18386
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 854bbdf2f10e9c33bc7ad4d5052ea532430fbf01
> data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
> ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
>
>
> Diff: https://reviews.apache.org/r/65173/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 65173: HIVE-18386
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/#review195524
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2431 (patched)
<https://reviews.apache.org/r/65173/#comment274713>
I wonder whether this config should be called hive.server2.materializedviews.registry.impl with possible values of dummy,default etc. That way in future id we decide to change registry implementation we can reuse this config.
That likely will also require to define an interface for this. But, that we can do later. Right now just changing name and value of config is sufficient, so that there are no user visible changes later.
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
Lines 141 (patched)
<https://reviews.apache.org/r/65173/#comment274714>
LOG.info
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
Line 249 (original), 282 (patched)
<https://reviews.apache.org/r/65173/#comment274715>
Caller of this method (Loader and Hook) has conf already they can pass it in. new HiveConf() is expensive.
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
Lines 392 (patched)
<https://reviews.apache.org/r/65173/#comment274716>
Caller should pass in conf.
service/src/java/org/apache/hive/service/server/HiveServer2.java
Line 192 (original), 192 (patched)
<https://reviews.apache.org/r/65173/#comment274717>
SessionHive should be well formed object here which can be passed in to callee. I see previous method is also using it. Any reason to not do that.
- Ashutosh Chauhan
On Jan. 16, 2018, 10:54 p.m., Jesús Camacho Rodríguez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65173/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 10:54 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Bugs: HIVE-18386
> https://issues.apache.org/jira/browse/HIVE-18386
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18386
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 854bbdf2f10e9c33bc7ad4d5052ea532430fbf01
> data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
> ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
> ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
> ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
>
>
> Diff: https://reviews.apache.org/r/65173/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jesús Camacho Rodríguez
>
>
Re: Review Request 65173: HIVE-18386
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65173/
-----------------------------------------------------------
(Updated Jan. 16, 2018, 10:54 p.m.)
Review request for hive, Ashutosh Chauhan and Thejas Nair.
Bugs: HIVE-18386
https://issues.apache.org/jira/browse/HIVE-18386
Repository: hive-git
Description
-------
HIVE-18386
Diffs (updated)
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 2cd3c95dc996671f4b176ab44f8584f039537e5f
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 854bbdf2f10e9c33bc7ad4d5052ea532430fbf01
data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 9b102f2a367f04b83e886e231b09f92e6be14088
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 7e5c81b6fd9a3264579585dd2043a27e7df72b4e
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java 80c7804dc1c40efecb61d28d4bb15da14c427054
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q PRE-CREATION
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out PRE-CREATION
ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java 58b8fb42f2d4c875333a2257f859d32853292002
Diff: https://reviews.apache.org/r/65173/diff/2/
Changes: https://reviews.apache.org/r/65173/diff/1-2/
Testing
-------
Thanks,
Jesús Camacho Rodríguez