You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/29 06:51:18 UTC

[GitHub] [arrow] thisisnic commented on a diff in pull request #14705: ARROW-15812: [R] Accept col_names in open_dataset for CSV

thisisnic commented on code in PR #14705:
URL: https://github.com/apache/arrow/pull/14705#discussion_r1034358862


##########
r/R/csv.R:
##########
@@ -478,7 +478,7 @@ CsvWriteOptions$create <- function(include_header = TRUE, batch_size = 1024L) {
   )
 }
 
-readr_to_csv_read_options <- function(skip, col_names, col_types) {
+readr_to_csv_read_options <- function(skip = 0, col_names = TRUE, col_types = NULL) {

Review Comment:
   Given it's not used here, should we just remove the `col_types` argument entirely?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org