[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2373: Fix bugs with CTE aliasing and normalize all identifiers in the SQL planner

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #2373:
URL: https://github.com/apache/arrow-datafusion/pull/2373#discussion_r862053422


##########
datafusion/core/tests/sql/information_schema.rs:
##########
@@ -307,14 +307,8 @@ async fn information_schema_show_columns() {
     let result = plan_and_collect(&ctx, "SHOW columns from t").await.unwrap();
     assert_batches_sorted_eq!(expected, &result);
 
-    // This isn't ideal but it is consistent behavior for `SELECT * from T`
-    let err = plan_and_collect(&ctx, "SHOW columns from T")

Review Comment:
   Good point! Updated!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org